Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package version 7.15.3 has a node engine version breaking change #82

Open
amirilovic opened this issue Oct 31, 2023 · 1 comment
Open

Comments

@amirilovic
Copy link

Hi, I noticed that in the engines section in package.json changed:

from:

 "engines": {
    "node": ">=12.0"
  },

to:

 "engines": {
    "node": ">=18.0"
  },

This can be considered a breaking change as it can break package install for dependant packages.

We had a problem with running cy2:

yarn global add [email protected]
cy2 run --browser chrome --parallel ....

The above script started failing two days ago as our CI agent as it runs node with version 16.x.x.

The error that we got was:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.0". Got "16.18.1"

in the end for us the fix was to use yarn --ignore-engines install flag.

I noticed that npm just issues a warning but executes the script.

@hallvors
Copy link

hallvors commented Feb 6, 2024

This is absolutely a breaking change.
We can not release updates for a site using Slonik because Slonik (we're on 33.0.3 at the moment) requires Roarr with a caret for version number, meaning all "minor" and "patch" versions are OK to update. So it attempts to update from 7.15.1 and this breaks the build since we're still on Node 16.

Both Roarr and Slonik should upgrade the major version number for such changes (ref gajus/slonik@v37.0.2...v37.0.3 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants