Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message filtering #63

Open
yosbelms opened this issue Aug 1, 2022 · 1 comment
Open

Improve message filtering #63

yosbelms opened this issue Aug 1, 2022 · 1 comment

Comments

@yosbelms
Copy link

yosbelms commented Aug 1, 2022

To filter logs currently it is necessary to parse the messages that it passed to ROARR.write in JSON format, resulting in a potentially CPU-intensive filtering logic.

My proposal is to pass unserialized message as second parameter to ROARR.write to avoid JSON parsing for each log message.

Context: gajus/slonik#277

@gajus
Copy link
Owner

gajus commented Jan 12, 2023

This needs to be opt-in, because the serializer that Roarr uses is part of the magic that makes Roarr so fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants