Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline-blocks does not enforce noZeroLineText with noMultilineBlocks #737

Closed
danvk opened this issue May 16, 2021 · 2 comments
Closed

Comments

@danvk
Copy link

danvk commented May 16, 2021

Expected behavior

The multiline-blocks rule normally disallows text on the zeroth line of a multiline block.

The code sample below produces the following error if you change the config to { noZeroLineText: true }:

Should have no text on the "0th" line (after the `/**`). eslintjsdoc/multiline-blocks

Actual behavior

If you set noMultilineBlocks and minimumLengthForMultiline, however,noZeroLineText is no longer enforced for longer comments. The example below is not flagged as an error.

ESLint Config

{
  noZeroLineText: true,
  noMultilineBlocks: true,
  minimumLengthForMultiline: 50
}

ESLint sample

/** This comment is bad
 * It should not have text on line zero.
 */

Environment

  • Node version: v12.16.3
  • ESLint version v7.9.0
  • eslint-plugin-jsdoc version: 34.6.1
@gajus
Copy link
Owner

gajus commented May 16, 2021

🎉 This issue has been resolved in version 34.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 16, 2021
@danvk
Copy link
Author

danvk commented May 16, 2021

Confirmed the fix, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants