-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test expecting space #113
Test expecting space #113
Conversation
brettz9
commented
Dec 7, 2018
- Fix failing test by adding missing space (as added by rule along with newline)
This extra space is going to be stripped by rules declared in The fix should happen in the rule, i.e. space should not be required. |
4e1e41b
to
60bc27b
Compare
I guess you mean the space should not be added in the rule rather than not be "required" in the rule. I've amended and force-pushed such a change. |
Whats the reason you are using force push? |
Thank you |
🎉 This PR is included in version 3.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sure, my pleasure... I force-pushed as I recall getting rejected from pushing with amended commits (and you'd otherwise have my original commit, undoing that commit, and the second commit all together)... |
You can just |