Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test expecting space #113

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Test expecting space #113

merged 1 commit into from
Dec 7, 2018

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented Dec 7, 2018

  • Fix failing test by adding missing space (as added by rule along with newline)

@gajus
Copy link
Owner

gajus commented Dec 7, 2018

This extra space is going to be stripped by rules declared in .editorconfig.

The fix should happen in the rule, i.e. space should not be required.

@gajus gajus added the bug label Dec 7, 2018
@brettz9 brettz9 force-pushed the space-with-newline branch from 4e1e41b to 60bc27b Compare December 7, 2018 14:02
@brettz9
Copy link
Collaborator Author

brettz9 commented Dec 7, 2018

I guess you mean the space should not be added in the rule rather than not be "required" in the rule.

I've amended and force-pushed such a change.

@gajus
Copy link
Owner

gajus commented Dec 7, 2018

I've amended and force-pushed such a change.

Whats the reason you are using force push?

@gajus gajus merged commit efdeea4 into gajus:master Dec 7, 2018
@gajus
Copy link
Owner

gajus commented Dec 7, 2018

Thank you

@gajus
Copy link
Owner

gajus commented Dec 7, 2018

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Dec 7, 2018
@brettz9
Copy link
Collaborator Author

brettz9 commented Dec 7, 2018

Sure, my pleasure... I force-pushed as I recall getting rejected from pushing with amended commits (and you'd otherwise have my original commit, undoing that commit, and the second commit all together)...

@brettz9 brettz9 deleted the space-with-newline branch December 7, 2018 14:13
@gajus
Copy link
Owner

gajus commented Dec 7, 2018

and you'd otherwise have my original commit, undoing that commit, and the second commit all together

You can just git revert ... && git commit [new changes] && git push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants