Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only include relevant files in published package #399

Conversation

gustavkj
Copy link
Collaborator

I realized that all files are included in the published package, when only the the generated files in the build and dist directories are needed (apart from the package.json etc).

Screenshot 2024-01-12 at 16 40 08

So with this change, only the needed files are included in the published package (the content after extracting the tarball generated by npm pack):

Screenshot 2024-01-12 at 16 43 12

@gustavkj gustavkj requested a review from gagoar January 12, 2024 15:44
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7504332720

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7504141116: 0.0%
Covered Lines: 266
Relevant Lines: 266

💛 - Coveralls

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64b1e41) 100.00% compared to head (30ca14a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          287       287           
  Branches        67        67           
=========================================
  Hits           287       287           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@gagoar gagoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is odd. I feel we had this already. all my other projects do 🤔

@gagoar gagoar merged commit 3bff598 into gagoar:master Jan 15, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants