Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for ArrayLike objects #236

Closed
AvraamMavridis opened this issue Jan 31, 2016 · 1 comment
Closed

support for ArrayLike objects #236

AvraamMavridis opened this issue Jan 31, 2016 · 1 comment

Comments

@AvraamMavridis
Copy link

Currently some of the ArrayLike objects are not "printed correctly" in the dock, e,g, ImmutableJS data structures, because of the way lodash"s identity function works. e.g. if you have a List you probably are interested for its contents rather than its internal representation.

Lodash`s identity in this case will return:

  Object {size: 4, _origin: 0, _capacity: 4, _level: 5, _root: null…}

...but you probably want to see the contents of the List and not the List's internal representation

if ( isArrayLikeObject ( listOnTheState ) )
{
  identity( listOnTheState ).toArray(); 
}

Is there any plan for supporting ArrayLike objects like this? If this is indeed an issue I can provide the PR.

@gaearon
Copy link
Contributor

gaearon commented Feb 2, 2016

Where do you see identity being used? identity is just a function that returns its argument so we're not "using" it in any specific sense. Also log monitor has its own repository which is probably where you'd like to report the issue. Under the hood it uses react-json-tree which should support any Iterables. If you can reproduce the issue with react-json-tree, please file it there. I don't think there's anything actionable in this repo, so I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants