Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2023.4 models param #162

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Support 2023.4 models param #162

merged 3 commits into from
Mar 28, 2024

Conversation

gabrielfeo
Copy link
Owner

2023.4 supports passing a models parameter to /api/builds to get GradleAttributes and others in a single request. getGradleAttributesFlow is deprecated in favor of the new parameter.

Copy link
Contributor

Generated API diff

diff -ur ./base-ref-api/src/main/kotlin/com/gabrielfeo/gradle/enterprise/api/model/BuildModelName.kt ./pr-ref-api/src/main/kotlin/com/gabrielfeo/gradle/enterprise/api/model/BuildModelName.kt
--- ./base-ref-api/src/main/kotlin/com/gabrielfeo/gradle/enterprise/api/model/BuildModelName.kt	2024-03-28 01:04:18.950806050 +0000
+++ ./pr-ref-api/src/main/kotlin/com/gabrielfeo/gradle/enterprise/api/model/BuildModelName.kt	2024-03-28 01:03:58.450758180 +0000
@@ -22,35 +22,35 @@
 /**
  * Build model names that can be requested when fetching builds.
  *
- * Values: gradleMinusAttributes,gradleMinusBuildMinusCacheMinusPerformance,gradleMinusProjects,gradleMinusNetworkMinusActivity,mavenMinusAttributes,mavenMinusBuildMinusCacheMinusPerformance,mavenMinusModules,mavenMinusDependencyMinusResolution
+ * Values: gradleAttributes,gradleBuildCachePerformance,gradleProjects,gradleNetworkActivity,mavenAttributes,mavenBuildCachePerformance,mavenModules,mavenDependencyResolution
  */
 
 @JsonClass(generateAdapter = false)
 enum class BuildModelName(val value: kotlin.String) {
 
     @Json(name = "gradle-attributes")
-    gradleMinusAttributes("gradle-attributes"),
+    gradleAttributes("gradle-attributes"),
 
     @Json(name = "gradle-build-cache-performance")
-    gradleMinusBuildMinusCacheMinusPerformance("gradle-build-cache-performance"),
+    gradleBuildCachePerformance("gradle-build-cache-performance"),
 
     @Json(name = "gradle-projects")
-    gradleMinusProjects("gradle-projects"),
+    gradleProjects("gradle-projects"),
 
     @Json(name = "gradle-network-activity")
-    gradleMinusNetworkMinusActivity("gradle-network-activity"),
+    gradleNetworkActivity("gradle-network-activity"),
 
     @Json(name = "maven-attributes")
-    mavenMinusAttributes("maven-attributes"),
+    mavenAttributes("maven-attributes"),
 
     @Json(name = "maven-build-cache-performance")
-    mavenMinusBuildMinusCacheMinusPerformance("maven-build-cache-performance"),
+    mavenBuildCachePerformance("maven-build-cache-performance"),
 
     @Json(name = "maven-modules")
-    mavenMinusModules("maven-modules"),
+    mavenModules("maven-modules"),
 
     @Json(name = "maven-dependency-resolution")
-    mavenMinusDependencyMinusResolution("maven-dependency-resolution");
+    mavenDependencyResolution("maven-dependency-resolution");
 
     /**
      * Override [toString()] to avoid using the enum variable name as the value, and instead use

@gabrielfeo gabrielfeo marked this pull request as ready for review March 28, 2024 13:42
@gabrielfeo gabrielfeo merged commit 379a050 into main Mar 28, 2024
8 checks passed
@gabrielfeo gabrielfeo deleted the gaf/model-param-support branch March 28, 2024 13:42
@gabrielfeo gabrielfeo restored the gaf/model-param-support branch November 30, 2024 02:55
@gabrielfeo gabrielfeo deleted the gaf/model-param-support branch January 6, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant