Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate hooks ProjectsRegistry~setCurrentProject(project) and ProjectsRegistry~createProject(projectConfig) #320

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Feb 7, 2023

Start addressing: #67


As a result of: #150 the intent is to bring the development environment ever closer to the production one. Consequently in a near future these lines of code will no longer be useful for local development:

g3wsdk.core.project.ProjectsRegistry.onbefore('createProject', (projectConfig) => {});
g3wsdk.core.project.ProjectsRegistry.onafter('createProject', (projectConfig) => {});
g3wsdk.core.project.ProjectsRegistry.onbefore('setCurrentProject', (project) => {});
g3wsdk.core.project.ProjectsRegistry.onafter('setCurrentProject', (project) => {});

Related to: #89, #292 and g3w-suite/g3w-suite-docker#79

…ProjectsRegistry~createProject(projectConfig)`

Start addressing: #67

As a result of: #150 we intend to bring the development environment ever closer to the production one.

Related to: #89, #292 and g3w-suite/g3w-suite-docker#79
@Raruto Raruto added the refactoring Anything which could result in a API change label Feb 7, 2023
@Raruto Raruto added this to the v3.8 milestone Feb 7, 2023
@Raruto Raruto marked this pull request as ready for review February 7, 2023 15:35
@Raruto Raruto changed the title Deprecate setters ProjectsRegistry~setCurrentProject(project) and ProjectsRegistry~createProject(projectConfig) Deprecate hooks ProjectsRegistry~setCurrentProject(project) and ProjectsRegistry~createProject(projectConfig) Feb 9, 2023
@volterra79 volterra79 modified the milestones: v3.8, v3.9 May 2, 2023
# Conflicts:
#	src/app/gui/queryresults/queryresultsservice.js
@volterra79 volterra79 modified the milestones: v3.9, v4.0 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants