Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure "pub points" not to be low #32

Closed
fzyzcjy opened this issue Oct 6, 2021 · 6 comments
Closed

Ensure "pub points" not to be low #32

fzyzcjy opened this issue Oct 6, 2021 · 6 comments

Comments

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 6, 2021

No description provided.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Oct 6, 2021

naive run:

(base) ➜  frb_dart git:(master) pana --no-warning
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart --version`...
INFO       Running `flutter --no-version-check --version --machine`...
INFO       Running `git rev-parse --show-toplevel`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub upgrade --verbose`...
INFO       Analyzing package...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart analyze --format machine lib`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart format --output=none --set-exit-if-changed /private/var/folders/pd/mpc7mwfj36ndyr9xbnnzk_s80000gn/T/pana_K6yyFB/frb_dart/lib`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub get .`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub outdated --json --up-to-date --no-dev-dependencies --no-dependency-overrides`...

## ✓ Follow Dart file conventions (20 / 20)
### [*] 10/10 points: Provide a valid `pubspec.yaml`


### [*] 5/5 points: Provide a valid `README.md`


### [*] 5/5 points: Provide a valid `CHANGELOG.md`


## ✗ Provide documentation (0 / 10)
### [x] 0/10 points: Package has an example

<details>
<summary>
No example found.
</summary>

See [package layout](https://dart.dev/tools/pub/package-layout#examples) guidelines on how to add an example.
</details>

## ✗ Support multiple platforms (10 / 20)
### [~] 10/20 points: Supports 1 of 2 possible platforms (**native**, js)


Consider supporting multiple platforms:

<details>
<summary>
Package not compatible with runtime js
</summary>

Because:
* `package:flutter_rust_bridge/flutter_rust_bridge.dart` that imports:
* `package:flutter_rust_bridge/src/basic.dart` that imports:
* `package:flutter_rust_bridge/src/utils.dart` that imports:
* `dart:isolate`
</details>

## ✗ Pass static analysis (20 / 30)
### [~] 20/30 points: code has no errors, warnings, lints, or formatting issues

<details>
<summary>
lib/src/basic.dart doesn't match the Dart formatter.
</summary>

To format your files run: `dart format .`
</details>
<details>
<summary>
lib/src/utils.dart doesn't match the Dart formatter.
</summary>

To format your files run: `dart format .`
</details>

## ✓ Support up-to-date dependencies (20 / 20)
### [*] 10/10 points: All of the package dependencies are supported in the latest version

|Package|Constraint|Compatible|Latest|
|:-|:-|:-|:-|
|[`lints`]|`^1.0.1`|1.0.1|1.0.1|
|[`meta`]|`^1.3.0`|1.7.0|1.7.0|

To reproduce run `dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides`.

[`lints`]: https://pub.dev/packages/lints
[`meta`]: https://pub.dev/packages/meta


### [*] 10/10 points: Package supports latest stable Dart and Flutter SDKs


## ✓ Support sound null safety (20 / 20)
### [*] 20/20 points: Package and dependencies are fully migrated to null safety!


Points: 90/120.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Oct 6, 2021

run again with more param

(base) ➜  frb_dart git:(master) ✗ pana --no-warning --line-length 120 --exit-code-threshold 0
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart --version`...
INFO       Running `flutter --no-version-check --version --machine`...
INFO       Running `git rev-parse --show-toplevel`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub upgrade --verbose`...
INFO       Analyzing package...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart analyze --format machine lib`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart format --output=none --set-exit-if-changed --line-length 120 /private/var/folders/pd/mpc7mwfj36ndyr9xbnnzk_s80000gn/T/pana_c3QEXv/frb_dart/lib`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub get .`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub outdated --json --up-to-date --no-dev-dependencies --no-dependency-overrides`...

## ✓ Follow Dart file conventions (20 / 20)
### [*] 10/10 points: Provide a valid `pubspec.yaml`


### [*] 5/5 points: Provide a valid `README.md`


### [*] 5/5 points: Provide a valid `CHANGELOG.md`


## ✗ Provide documentation (0 / 10)
### [x] 0/10 points: Package has an example

<details>
<summary>
No example found.
</summary>

See [package layout](https://dart.dev/tools/pub/package-layout#examples) guidelines on how to add an example.
</details>

## ✗ Support multiple platforms (10 / 20)
### [~] 10/20 points: Supports 1 of 2 possible platforms (**native**, js)


Consider supporting multiple platforms:

<details>
<summary>
Package not compatible with runtime js
</summary>

Because:
* `package:flutter_rust_bridge/flutter_rust_bridge.dart` that imports:
* `package:flutter_rust_bridge/src/basic.dart` that imports:
* `package:flutter_rust_bridge/src/utils.dart` that imports:
* `dart:isolate`
</details>

## ✓ Pass static analysis (30 / 30)
### [*] 30/30 points: code has no errors, warnings, lints, or formatting issues


## ✓ Support up-to-date dependencies (20 / 20)
### [*] 10/10 points: All of the package dependencies are supported in the latest version

|Package|Constraint|Compatible|Latest|
|:-|:-|:-|:-|
|[`lints`]|`^1.0.1`|1.0.1|1.0.1|
|[`meta`]|`^1.3.0`|1.7.0|1.7.0|

To reproduce run `dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides`.

[`lints`]: https://pub.dev/packages/lints
[`meta`]: https://pub.dev/packages/meta


### [*] 10/10 points: Package supports latest stable Dart and Flutter SDKs


## ✓ Support sound null safety (20 / 20)
### [*] 20/20 points: Package and dependencies are fully migrated to null safety!


Points: 100/120.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Oct 6, 2021

related dart-lang/pana#975

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Oct 6, 2021

Now better. but still 120 not 130.

(base) ➜  frb_dart git:(master) ✗ pana --no-warning --line-length 120 --exit-code-threshold 0
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart --version`...
INFO       Running `flutter --no-version-check --version --machine`...
INFO       Running `git rev-parse --show-toplevel`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub upgrade --verbose`...
INFO       Analyzing package...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart analyze --format machine lib`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart format --output=none --set-exit-if-changed --line-length 120 /private/var/folders/pd/mpc7mwfj36ndyr9xbnnzk_s80000gn/T/pana_gInuvR/frb_dart/lib`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub get .`...
INFO       Running `/Users/tom/opt/flutter/bin/cache/dart-sdk/bin/dart pub outdated --json --up-to-date --no-dev-dependencies --no-dependency-overrides`...

## ✓ Follow Dart file conventions (20 / 20)
### [*] 10/10 points: Provide a valid `pubspec.yaml`


### [*] 5/5 points: Provide a valid `README.md`


### [*] 5/5 points: Provide a valid `CHANGELOG.md`


## ✓ Provide documentation (10 / 10)
### [*] 10/10 points: Package has an example

* Found example at: `example/main.dart`

## ✓ Support multiple platforms (20 / 20)
### [*] 20/20 points: Supports 2 of 2 possible platforms (**native**, **js**)


## ✓ Pass static analysis (30 / 30)
### [*] 30/30 points: code has no errors, warnings, lints, or formatting issues


## ✓ Support up-to-date dependencies (20 / 20)
### [*] 10/10 points: All of the package dependencies are supported in the latest version

|Package|Constraint|Compatible|Latest|
|:-|:-|:-|:-|
|[`lints`]|`^1.0.1`|1.0.1|1.0.1|
|[`meta`]|`^1.3.0`|1.7.0|1.7.0|

To reproduce run `dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides`.

[`lints`]: https://pub.dev/packages/lints
[`meta`]: https://pub.dev/packages/meta


### [*] 10/10 points: Package supports latest stable Dart and Flutter SDKs


## ✓ Support sound null safety (20 / 20)
### [*] 20/20 points: Package and dependencies are fully migrated to null safety!


Points: 120/120.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Oct 6, 2021

related: dart-lang/pub-dev#3956

@fzyzcjy fzyzcjy closed this as completed Oct 6, 2021
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fzyzcjy