Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to use COMTE and TSR but facing when plotting features #43 #44

Closed
JanaSw opened this issue Sep 17, 2023 · 5 comments
Closed

Trying to use COMTE and TSR but facing when plotting features #43 #44

JanaSw opened this issue Sep 17, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@JanaSw
Copy link

JanaSw commented Sep 17, 2023

Hello,

I am doing multivariate time series classification with 2 features.
When using the plot function with either COMTE or TSR only a portion of the features are being plotted for each instance.

When I debugged I suspected an issue with the reshape done in the plot.

BEFORE Reshape: In the below screenshot is the item values we can see 2 features starting both from 0 value:

image

AFTER Reshape: here we see that the reshape didn't conserve all the values of the feature (we can that not both features are starting at 0)

image

This is happening inside both plot functions: plot_in_one in CF.py at line 181 when it reshape the item
and plot in Saliency_Base.py at line 61 when it reshape the item

Note: I am using tensorflow

can you please help ? am I missing something or there is a bug ?

@JHoelli JHoelli self-assigned this Sep 18, 2023
@JHoelli JHoelli added the bug Something isn't working label Sep 18, 2023
@JanaSw JanaSw closed this as completed Sep 18, 2023
@JanaSw JanaSw reopened this Sep 18, 2023
@JanaSw
Copy link
Author

JanaSw commented Sep 18, 2023

Hello @JHoelli

Thank you for your reactivity !

Since you marked it as a bug do you have any estimations when will you submit a fix?

@JHoelli
Copy link
Contributor

JHoelli commented Sep 18, 2023

Hi,

I am currently fixing it. I hope to finish it in a few hours (afternnon / evening CEST ). (Checking for side effects unfortunately needs some time).

@JHoelli JHoelli mentioned this issue Sep 18, 2023
@JHoelli
Copy link
Contributor

JHoelli commented Sep 18, 2023

Hi @JanaSw,

you can install the patch with pip install https://github.com/fzi-forschungszentrum-informatik/TSInterpret/archive/refs/heads/swpaxes.zip would be great if you could provide feedback, before I merge everything into the main branch.

Thanks for reporting the issue.

@JanaSw
Copy link
Author

JanaSw commented Sep 18, 2023

Hello @JHoelli

I tested it and debugged and checked the values it is indeed working now :)

Thanks again for your reactivity !!

@JHoelli
Copy link
Contributor

JHoelli commented Sep 18, 2023

Great, I just merged it in the Main Branch.
The code will be available via PyPi with Release 0.4.4. (The release might take one or two more weeks.)

@JHoelli JHoelli closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants