Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple search field from map #50

Closed
giorgio79 opened this issue Jul 2, 2020 · 3 comments
Closed

Decouple search field from map #50

giorgio79 opened this issue Jul 2, 2020 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@giorgio79
Copy link

Perhaps, you could integrate with one of these

@fysoul17
Copy link
Owner

fysoul17 commented Jul 4, 2020

Hi @giorgio79,
Thanks for the suggestion. ;) It will help ones who want to fork and use in their own way.

However, decoupling isn't a big issue in terms of coding. I can just put an optional parameter to turn it off. The issue is the purpose of the package. The package originally made for users to pick the location by using autocomplete search and by dragging the pin which is the secondary option to pick.

So making the main function as optional sounds weird for me. I will think about providing an optional parameter on the next version, but I am not sure whether it will be useful for most cases.

@fysoul17 fysoul17 added the documentation Improvements or additions to documentation label Jul 4, 2020
@fysoul17 fysoul17 pinned this issue Jul 4, 2020
@giorgio79
Copy link
Author

giorgio79 commented Jul 4, 2020

Yeah just an idea. Maybe not optional, but breaking it apart in the backend may make it more manageable. :)

@fysoul17 fysoul17 closed this as completed Jul 4, 2020
@abrantesarthur
Copy link

Hi there,

I understand that removing the search field would go against the primary purpose of the package, but I would also greatly appreciate if you could introduce an optional parameter to turn it off. I have a use case where such a feature would be awesome.

Thank you so much for your contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants