Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package command fails on OpenBSD #5195

Open
2 tasks done
sdassow opened this issue Oct 14, 2024 · 6 comments
Open
2 tasks done

Package command fails on OpenBSD #5195

sdassow opened this issue Oct 14, 2024 · 6 comments
Assignees
Labels
unverified A bug that has been reported but not verified

Comments

@sdassow
Copy link
Contributor

sdassow commented Oct 14, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

OpenBSD tar does not support the -J flag and fails during fyne package.

How to reproduce

Run fyne package --os openbsd --release on OpenBSD.

Screenshots

No response

Example code

Any code.

Fyne version

any

Go compiler version

any

Operating system and version

OpenBSD any version

Additional Information

No response

@sdassow sdassow added the unverified A bug that has been reported but not verified label Oct 14, 2024
@andydotxyz
Copy link
Member

Ah shoot. When we moved to .xz checks were made to ensure it was supported everywhere. we missed this.

Can it be enabled through an external plugin or will we need to revert to .tar.gz for BSD usages?

@sdassow
Copy link
Contributor Author

sdassow commented Oct 14, 2024

We could use gtar (GNU tar) instead, which can be installed from packages/ports.

@sdassow
Copy link
Contributor Author

sdassow commented Oct 14, 2024

First off, this is on OpenBSD only, the others I checked (NetBSD, FreeBSD, DragonflyBSD) support it.

Other than that, using gtar wouldn't be the best user experience since it means installing something else first.

@andydotxyz
Copy link
Member

Other than that, using gtar wouldn't be the best user experience since it means installing something else first.

Unusual for someone to reply to their own suggestion going against it ;).

It sounds like we have no choice - should we just create .gz when run on OpenBSD? I'm not sure it matters too much.
It may also mean we have to use that when packaging /for/ openBSD as well, or you won't be able to open the archives.

@sdassow
Copy link
Contributor Author

sdassow commented Oct 17, 2024

Other than that, using gtar wouldn't be the best user experience since it means installing something else first.

Unusual for someone to reply to their own suggestion going against it ;).

Just thinking out loud ;).

It sounds like we have no choice - should we just create .gz when run on OpenBSD? I'm not sure it matters too much.

I'll have a look and brew something up. When I found this I just created an issue for later.

It may also mean we have to use that when packaging /for/ openBSD as well, or you won't be able to open the archives.

For distribution it doesn't matter as much.
For source distribution not at all since that's usually handled in the ports tree for proper OpenBSD packaging as a build dependency.
For binary distribution it means a small inconvenience having to manually install GNU tar and/or xz first.

@andydotxyz
Copy link
Member

For binary distribution it means a small inconvenience having to manually install GNU tar and/or xz first.

Sorry I missed this before commenting on the PR.
Typically we want to put the package install / additional dependency on the developer not the end user. Is it a bad thing to adapt the fix so it avoids that compression for both developer and user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unverified A bug that has been reported but not verified
Projects
None yet
Development

No branches or pull requests

2 participants