Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.0 no more works with PHP less than 7.1 #43

Closed
gajdusek opened this issue Mar 9, 2022 · 2 comments
Closed

v1.2.0 no more works with PHP less than 7.1 #43

gajdusek opened this issue Mar 9, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@gajdusek
Copy link

gajdusek commented Mar 9, 2022

Thank you for creating this excellent composer plugin!

Commit 7d3d824 introduced at least one PHP 7.1+ feature, a nullable type, in

public function __construct(
        IOInterface $io,
        Config $config,
        ProcessExecutor $executor,
        Filesystem $fs,
        FallbackInterface $fallback = null,
        ?VersionConverterInterface $versionConverter = null
    ) {
        $this->io = $io;
        ...
   }

Despite this breaking change the foxy version number did not bump to 2.0.0 and composer.json still requires only php >= 5.3.3:

{
    ...
    "require": {
        "php": ">=5.3.3",
        ...
    },
    ...

This is the first error encountered when running composer with PHP < 7.1. Maybe there are more.

Petr

@francoispluchino francoispluchino added this to the 1.2 milestone Mar 9, 2022
@francoispluchino
Copy link
Member

I thank you for your feedback. This needs to be fixed.

@francoispluchino francoispluchino self-assigned this Apr 17, 2022
@francoispluchino
Copy link
Member

Fixed by c415403.

@francoispluchino francoispluchino changed the title foxy 1.2.0 no more works with PHP < 7.1 and should reflect this in composer.json and version number v1.2.0 no more works with PHP less than 7.1 Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants