-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package from single platform to multiple platforms #247
Comments
Hi @Osiris-Team! I'm not really sure what you are proposing here ... I've read your changes in PR #248, but I don't know what are Do you want that JavaPackager downloads a JDK automatically (if it's not downloaded yet)? |
|
Yeah, so that it's possible to build from a single platform to multiple platforms without the need of downloading the respective jdks for those platforms manually. |
How is this feature going on? I've tried to test pr-248 branch, but it seems you have some work in progress. I plan to add some other features and patches, so hopefully we won't run into a painful merge 😅 |
yeah the actual PR with the auto-jdk download is already done. This is already really painful though at the moment. I'm thinking of dropping this too and just stick to the old way. |
Have you considered utilizing Maven's toolchains feature? It would require someone to add an entry into their maven |
One thing that puzzles me is that I thought it was required that each platform must be packaged from that platform's operating system. Is this not the case? |
@EasyG0ing1 Guess you only need the platform-specific JDK and nothing more if you are building from windows to everything else. @fvarrui Managed to avoid the MojoExecutionException for maven, and now got a pretty nice structure (see MavenPackageTask and GradlePackageTask and PackageTask classes in my branch) |
@Osiris-Team Interesting, I'm now wondering what it is about windows that makes it easier for packagers to reference JDKs from the other platforms while it's not as easy to go the other way ... or maybe it's just a lack of anyone writing the packaging software for the other platforms (mac / Linux). |
Currently, the JDK path for other platforms needs to be specified manually, which means I have to download additional JDKs
for Linux and Mac, because I am on Windows and enter their paths.
I am proposing a solution to automate this:
this
C:\Users\<username>\AppData\Local\Temp\JavaPackager
).The
jdkPath
from the plugin config xml could then be removed or made optional.Additionally, we would add optional
jdkVersion
(default 8) andjdkVendor
(default temurin).I already got the download logic and API stuff implemented for another project,
so could use it for this one too:
PR would be ready in 1 hour.
Note that the above would probably make it possible to package from windows to all other platforms, but not from linux/mac to all other platforms, since the necessary native tools are not available on those platforms I guess.
The text was updated successfully, but these errors were encountered: