Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default template for winrun4j does not correctly specify/verify jvm.dll location for all runtimes #159

Closed
2 of 5 tasks
keastrid opened this issue Feb 26, 2022 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@keastrid
Copy link
Contributor

I'm submitting a…

  • bug report
  • feature request
  • other

Short description of the issue/suggestion:
Some java runtimes place the jvm.dll in /server rather than /client. Not sure why they have differing locations.

Steps to reproduce the issue/enhancement:

  1. Build and package with Azul Zulu JDK 17
  2. Attempt to run exe

What is the expected behavior?
Choosing the suitable path

What is the current behavior?
Hard specifying `/client``

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement?

AstroImageJ without the user-specified ini.vtl will display this behavior.

What is the motivation / use case for changing the behavior?
A bit of a surprise when it builds successfully and fails to run when the java distribution is present.

Please tell us about your environment:

  • JavaPackager version: 1.6.3
  • OS version: Windows 10
  • JDK version: 17
  • Build tool:
    • Maven
    • Gradle

Other information (e.g. related issues, suggestions how to fix, links for us to have context)

@fvarrui
Copy link
Owner

fvarrui commented Feb 27, 2022

Hi @keastrid!
In this issue you can find a solution proposal.

@fvarrui fvarrui added bug Something isn't working enhancement New feature or request labels Feb 27, 2022
@keastrid
Copy link
Contributor Author

The fallback behavior looks good!

@fvarrui
Copy link
Owner

fvarrui commented Feb 28, 2022

Fixed!

@fvarrui
Copy link
Owner

fvarrui commented Mar 3, 2022

JavaPackager 1.6.4 released to Maven Central.

@fvarrui fvarrui closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants