[INLONG-11153][Manager] Move the disable check to the first place of …

…createSinkResource method
fuweng11 · Sep 27, 2024 · f9c8fe2 · f9c8fe2
1 parent 9af47e1
commit f9c8fe2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/.../main/java/org/apache/inlong/manager/service/resource/sink/http/HttpResourceOperator.java b/.../main/java/org/apache/inlong/manager/service/resource/sink/http/HttpResourceOperator.java
@@ -43,12 +43,12 @@ public Boolean accept(String sinkType) {
     @Override
     public void createSinkResource(SinkInfo sinkInfo) {
         LOG.info("begin to create sink resources sinkId={}", sinkInfo.getId());
-        if (SinkStatus.CONFIG_SUCCESSFUL.getCode().equals(sinkInfo.getStatus())) {
-            LOG.warn("sink resource [" + sinkInfo.getId() + "] already success, skip to create");
-            return;
-        } else if (InlongConstants.DISABLE_CREATE_RESOURCE.equals(sinkInfo.getEnableCreateResource())) {
+        if (InlongConstants.DISABLE_CREATE_RESOURCE.equals(sinkInfo.getEnableCreateResource())) {
             LOG.warn("create resource was disabled, skip to create for [" + sinkInfo.getId() + "]");
             return;
+        } else if (SinkStatus.CONFIG_SUCCESSFUL.getCode().equals(sinkInfo.getStatus())) {
+            LOG.warn("sink resource [" + sinkInfo.getId() + "] already success, skip to create");
+            return;
         }
         this.checkTaskAndConsumerGroup(sinkInfo);
         this.assignCluster(sinkInfo);