Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 supports ANSI natively #63

Closed
cowwoc opened this issue Aug 12, 2016 · 4 comments
Closed

Windows 10 supports ANSI natively #63

cowwoc opened this issue Aug 12, 2016 · 4 comments

Comments

@cowwoc
Copy link

cowwoc commented Aug 12, 2016

Please update the library taking http://superuser.com/a/1105718/57662 into consideration.

@hboutemy
Copy link
Collaborator

Should we remove the JAnsi System.out tweaking for any Windows 10 version?
Or should we try to check for a minimal build?
Any PR?

@gnodet
Copy link
Member

gnodet commented May 2, 2017

It seems that this support has been removed from Windows 10:
symfony/symfony#19520

@gnodet gnodet closed this as completed May 2, 2017
@cowwoc
Copy link
Author

cowwoc commented May 2, 2017

@gnodet It's not removed but rather disabled by default. See microsoft/WSL#1173

All this is to say that you need native code to activate support.

@gnodet
Copy link
Member

gnodet commented May 2, 2017

So it seems what would be needed is to call setConsoleMode(ENABLE_VIRTUAL_TERMINAL_PROCESSING) when Windows 10 is detected.
Additionally, we'd need to detect windows 10 ;-)

I don't really see that as a priority though, given jansi aims to provide the same thing on all windows versions, and this is also working for Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants