fix: artist page link sending to artist page #825
Conversation
✅ Deploy Preview for mirlo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
asartalo
force-pushed
the
asartalo/artist-page-link-bug
branch
from
22afe7b to
3dab939
Compare
|
Actually, this solution is not as simple as I thought it would be so I'll need more guidance. The changes I made in this PR affects a lot of other components external to the artist page since the component |
| {trackGroup.artist?.name} | ||
| </Link> | ||
| )} | ||
| {<ArtistName artist={trackGroup.artist} />} |
There was a problem hiding this comment.
Do you have Prettier enabled for this project? This should automatically turn this into:
| {<ArtistName artist={trackGroup.artist} />} | |
| <ArtistName artist={trackGroup.artist} /> |
decluttering it a little bit. It's an outstanding project to add it to the repo by detault
There was a problem hiding this comment.
lgtm! thank you!
Edit: ah I'm seeing your message now, let me look
Edit 2: Okay, it looks like TrackGroupInfo is kind of a misnomer, as it gets used for ArtistSquares as well (which is just the list of artists, in the same format as the trackgroups. A rename there might be in order (maybe something as simple as InfoUnderSquare?), but feel free to consider that out of the scope of this PR. I feel like a simple solution is to change the names of the classes you create eg. .track-group-name becomes .first-title and then adding that class name to the ArtistSquare
Fixes #797.
Hello. This is my first contribution to the project so please let me know if there are any conventions that I should follow.