From f993b9c5b5a24377d5b55d789115c488496ff1b5 Mon Sep 17 00:00:00 2001 From: Sander Muller Date: Fri, 26 Apr 2024 16:22:29 +0200 Subject: [PATCH 01/16] Fix return types of `firstWhere` and `first` of `BelongsToMany` and `HasManyThrough` (#51219) * Fix return types of firstWhere and first of BelongsToMany * Fix return types of HasManyThrough --- src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php | 4 ++-- src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php b/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php index 7a90dc998cc0..ef17cce6371c 100755 --- a/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php +++ b/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php @@ -784,7 +784,7 @@ public function findOr($id, $columns = ['*'], ?Closure $callback = null) * @param mixed $operator * @param mixed $value * @param string $boolean - * @return \Illuminate\Database\Eloquent\Model|static + * @return \Illuminate\Database\Eloquent\Model|static|null */ public function firstWhere($column, $operator = null, $value = null, $boolean = 'and') { @@ -795,7 +795,7 @@ public function firstWhere($column, $operator = null, $value = null, $boolean = * Execute the query and get the first result. * * @param array $columns - * @return mixed + * @return \Illuminate\Database\Eloquent\Model|static|null */ public function first($columns = ['*']) { diff --git a/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php b/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php index 70dd922b20b0..2f3dc31fef60 100644 --- a/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php +++ b/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php @@ -320,7 +320,7 @@ public function updateOrCreate(array $attributes, array $values = []) * @param mixed $operator * @param mixed $value * @param string $boolean - * @return \Illuminate\Database\Eloquent\Model|static + * @return \Illuminate\Database\Eloquent\Model|static|null */ public function firstWhere($column, $operator = null, $value = null, $boolean = 'and') { @@ -331,7 +331,7 @@ public function firstWhere($column, $operator = null, $value = null, $boolean = * Execute the query and get the first related model. * * @param array $columns - * @return mixed + * @return \Illuminate\Database\Eloquent\Model|static|null */ public function first($columns = ['*']) { From 89462a71233011cd10e554b002ab1c005e5cf979 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Sandstr=C3=B6m=20Krisell?= Date: Mon, 29 Apr 2024 08:51:46 +0200 Subject: [PATCH 02/16] Fix typo in signed URL tampering tests (#51238) --- tests/Routing/RoutingUrlGeneratorTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Routing/RoutingUrlGeneratorTest.php b/tests/Routing/RoutingUrlGeneratorTest.php index 2c6079adf36b..c612affaa44b 100755 --- a/tests/Routing/RoutingUrlGeneratorTest.php +++ b/tests/Routing/RoutingUrlGeneratorTest.php @@ -764,7 +764,7 @@ public function testSignedUrl() $this->assertTrue($url->hasValidSignature($request)); - $request = Request::create($url->signedRoute('foo').'?tempered=true'); + $request = Request::create($url->signedRoute('foo').'?tampered=true'); $this->assertFalse($url->hasValidSignature($request)); } @@ -812,7 +812,7 @@ public function testSignedRelativeUrl() $this->assertTrue($url->hasValidSignature($request, false)); - $request = Request::create($url->signedRoute('foo', [], null, false).'?tempered=true'); + $request = Request::create($url->signedRoute('foo', [], null, false).'?tampered=true'); $this->assertFalse($url->hasValidSignature($request, false)); } @@ -891,7 +891,7 @@ public function testSignedUrlWithKeyResolver() $this->assertTrue($url->hasValidSignature($request)); - $request = Request::create($url->signedRoute('foo').'?tempered=true'); + $request = Request::create($url->signedRoute('foo').'?tampered=true'); $this->assertFalse($url->hasValidSignature($request)); From 236ee6df345fe2cac8ce020348ee57e6b8e07e8d Mon Sep 17 00:00:00 2001 From: Julius Kiekbusch Date: Mon, 29 Apr 2024 15:23:17 +0200 Subject: [PATCH 03/16] Add "Server has gone away" to DetectsLostConnection (#51241) --- src/Illuminate/Database/DetectsLostConnections.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Illuminate/Database/DetectsLostConnections.php b/src/Illuminate/Database/DetectsLostConnections.php index f946f35dc59c..8cb1187a8bb7 100644 --- a/src/Illuminate/Database/DetectsLostConnections.php +++ b/src/Illuminate/Database/DetectsLostConnections.php @@ -19,6 +19,7 @@ protected function causedByLostConnection(Throwable $e) return Str::contains($message, [ 'server has gone away', + 'Server has gone away', 'no connection to the server', 'Lost connection', 'is dead or not enabled', From e38d945fce91860c29f10a6bd4a19790ff25ad84 Mon Sep 17 00:00:00 2001 From: "S.a Mahmoudzadeh" <36761585+saMahmoudzadeh@users.noreply.github.com> Date: Mon, 29 Apr 2024 16:53:52 +0330 Subject: [PATCH 04/16] [11.x] Add some tests in `SupportStrTest` class (#51235) * improvement tests for beforeLast method * improvement tests for Str::words * improvement tests * fixes code style --- tests/Support/SupportStrTest.php | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/Support/SupportStrTest.php b/tests/Support/SupportStrTest.php index 909699b7a266..1bd26cbde1c3 100755 --- a/tests/Support/SupportStrTest.php +++ b/tests/Support/SupportStrTest.php @@ -12,11 +12,13 @@ class SupportStrTest extends TestCase { - public function testStringCanBeLimitedByWords() + public function testStringCanBeLimitedByWords(): void { $this->assertSame('Taylor...', Str::words('Taylor Otwell', 1)); $this->assertSame('Taylor___', Str::words('Taylor Otwell', 1, '___')); $this->assertSame('Taylor Otwell', Str::words('Taylor Otwell', 3)); + $this->assertSame('Taylor Otwell', Str::words('Taylor Otwell', -1, '...')); + $this->assertSame('', Str::words('', 3, '...')); } public function testStringCanBeLimitedByWordsNonAscii() @@ -114,11 +116,13 @@ public function testStringApa() $this->assertSame(' ', Str::apa(' ')); } - public function testStringWithoutWordsDoesntProduceError() + public function testStringWithoutWordsDoesntProduceError(): void { $nbsp = chr(0xC2).chr(0xA0); $this->assertSame(' ', Str::words(' ')); $this->assertEquals($nbsp, Str::words($nbsp)); + $this->assertSame(' ', Str::words(' ')); + $this->assertSame("\t\t\t", Str::words("\t\t\t")); } public function testStringAscii() @@ -265,7 +269,7 @@ public function testStrBefore() $this->assertSame('han', Str::before('han2nah', 2)); } - public function testStrBeforeLast() + public function testStrBeforeLast(): void { $this->assertSame('yve', Str::beforeLast('yvette', 'tte')); $this->assertSame('yvet', Str::beforeLast('yvette', 't')); @@ -276,6 +280,10 @@ public function testStrBeforeLast() $this->assertSame('yv0et', Str::beforeLast('yv0et0te', '0')); $this->assertSame('yv0et', Str::beforeLast('yv0et0te', 0)); $this->assertSame('yv2et', Str::beforeLast('yv2et2te', 2)); + $this->assertSame('', Str::beforeLast('', 'test')); + $this->assertSame('', Str::beforeLast('yvette', 'yvette')); + $this->assertSame('laravel', Str::beforeLast('laravel framework', ' ')); + $this->assertSame('yvette', Str::beforeLast("yvette\tyv0et0te", "\t")); } public function testStrBetween() From 0bafaa8b4f7dccc2ab3e52fb896b4967352fe95c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Mon, 29 Apr 2024 16:41:28 +0200 Subject: [PATCH 05/16] [10.x] Fix support for the LARAVEL_STORAGE_PATH env var (#51238) (#51243) * [10.x] Fix support for the LARAVEL_STORAGE_PATH env var * formatting --------- Co-authored-by: Taylor Otwell --- src/Illuminate/Foundation/Application.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Illuminate/Foundation/Application.php b/src/Illuminate/Foundation/Application.php index 4bfd6a33e88e..780e03b81f8f 100755 --- a/src/Illuminate/Foundation/Application.php +++ b/src/Illuminate/Foundation/Application.php @@ -535,6 +535,10 @@ public function storagePath($path = '') return $this->joinPaths($this->storagePath ?: $_ENV['LARAVEL_STORAGE_PATH'], $path); } + if (isset($_SERVER['LARAVEL_STORAGE_PATH'])) { + return $this->joinPaths($this->storagePath ?: $_SERVER['LARAVEL_STORAGE_PATH'], $path); + } + return $this->joinPaths($this->storagePath ?: $this->basePath('storage'), $path); } From 83e1f56812ddeaca1a60f999cdd85c6f692e44b7 Mon Sep 17 00:00:00 2001 From: Evan Date: Mon, 29 Apr 2024 21:48:24 +0100 Subject: [PATCH 06/16] [11.x] Add replaceable tags to translations (#51190) * feat: add replaceable tags to translations * Update Translator.php * Update Translator.php --------- Co-authored-by: Taylor Otwell --- src/Illuminate/Translation/Translator.php | 10 ++++++ .../Translation/TranslationTranslatorTest.php | 36 +++++++++++++++++++ 2 files changed, 46 insertions(+) diff --git a/src/Illuminate/Translation/Translator.php b/src/Illuminate/Translation/Translator.php index 7b9ab9a56d6c..2a956830df98 100755 --- a/src/Illuminate/Translation/Translator.php +++ b/src/Illuminate/Translation/Translator.php @@ -262,6 +262,16 @@ protected function makeReplacements($line, array $replace) $shouldReplace = []; foreach ($replace as $key => $value) { + if ($value instanceof Closure) { + $line = preg_replace_callback( + '/<'.$key.'>(.*?)<\/'.$key.'>/', + fn ($args) => $value($args[1]), + $line + ); + + continue; + } + if (is_object($value) && isset($this->stringableHandlers[get_class($value)])) { $value = call_user_func($this->stringableHandlers[get_class($value)], $value); } diff --git a/tests/Translation/TranslationTranslatorTest.php b/tests/Translation/TranslationTranslatorTest.php index 07ec429aab77..6bf8092a6464 100755 --- a/tests/Translation/TranslationTranslatorTest.php +++ b/tests/Translation/TranslationTranslatorTest.php @@ -257,6 +257,42 @@ public function testGetJsonReplacesWithStringable() ); } + public function testTagReplacements() + { + $t = new Translator($this->getLoader(), 'en'); + + $t->getLoader()->shouldReceive('load')->once()->with('en', '*', '*')->andReturn([]); + $t->getLoader()->shouldReceive('load')->once()->with('en', 'We have some nice documentation', '*')->andReturn([]); + + $this->assertSame( + 'We have some nice documentation', + $t->get( + 'We have some nice documentation', + [ + "docs-link" => fn ($children) => "$children" + ] + ) + ); + } + + public function testTagReplacementsHandleMultipleOfSameTag() + { + $t = new Translator($this->getLoader(), 'en'); + + $t->getLoader()->shouldReceive('load')->once()->with('en', '*', '*')->andReturn([]); + $t->getLoader()->shouldReceive('load')->once()->with('en', 'bold something else also bold', '*')->andReturn([]); + + $this->assertSame( + 'bold something else also bold', + $t->get( + 'bold something else also bold', + [ + "bold-this" => fn ($children) => "$children" + ] + ) + ); + } + public function testDetermineLocalesUsingMethod() { $t = new Translator($this->getLoader(), 'en'); From 8a65c4d564c391c2b9fb7a557a9b0985a50dbf83 Mon Sep 17 00:00:00 2001 From: StyleCI Bot Date: Mon, 29 Apr 2024 20:48:44 +0000 Subject: [PATCH 07/16] Apply fixes from StyleCI --- tests/Translation/TranslationTranslatorTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Translation/TranslationTranslatorTest.php b/tests/Translation/TranslationTranslatorTest.php index 6bf8092a6464..86c8948ef94f 100755 --- a/tests/Translation/TranslationTranslatorTest.php +++ b/tests/Translation/TranslationTranslatorTest.php @@ -269,7 +269,7 @@ public function testTagReplacements() $t->get( 'We have some nice documentation', [ - "docs-link" => fn ($children) => "$children" + 'docs-link' => fn ($children) => "$children", ] ) ); @@ -287,7 +287,7 @@ public function testTagReplacementsHandleMultipleOfSameTag() $t->get( 'bold something else also bold', [ - "bold-this" => fn ($children) => "$children" + 'bold-this' => fn ($children) => "$children", ] ) ); From 44dba84f7aab8f0290c19cc2b62abce142185935 Mon Sep 17 00:00:00 2001 From: Caleb White Date: Tue, 30 Apr 2024 07:42:34 -0500 Subject: [PATCH 08/16] [10.x] fix: Factory::createMany creating n^2 records (#51225) * fix: Factory::createMany creating n^2 records * Update Factory.php --------- Co-authored-by: Taylor Otwell --- .../Database/Eloquent/Factories/Factory.php | 6 +++--- tests/Database/DatabaseEloquentFactoryTest.php | 16 ++++++++++++++++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/Illuminate/Database/Eloquent/Factories/Factory.php b/src/Illuminate/Database/Eloquent/Factories/Factory.php index d9a453359d23..e8c25101361b 100644 --- a/src/Illuminate/Database/Eloquent/Factories/Factory.php +++ b/src/Illuminate/Database/Eloquent/Factories/Factory.php @@ -240,9 +240,9 @@ public function createOneQuietly($attributes = []) */ public function createMany(int|iterable|null $records = null) { - if (is_null($records)) { - $records = $this->count ?? 1; - } + $records ??= ($this->count ?? 1); + + $this->count = null; if (is_numeric($records)) { $records = array_fill(0, $records, []); diff --git a/tests/Database/DatabaseEloquentFactoryTest.php b/tests/Database/DatabaseEloquentFactoryTest.php index f46ebc3213f2..cc3c78504554 100644 --- a/tests/Database/DatabaseEloquentFactoryTest.php +++ b/tests/Database/DatabaseEloquentFactoryTest.php @@ -129,14 +129,30 @@ public function test_basic_model_can_be_created() $users = FactoryTestUserFactory::new()->createMany(2); $this->assertInstanceOf(Collection::class, $users); $this->assertCount(2, $users); + $this->assertInstanceOf(FactoryTestUser::class, $users->first()); $users = FactoryTestUserFactory::times(2)->createMany(); $this->assertInstanceOf(Collection::class, $users); $this->assertCount(2, $users); + $this->assertInstanceOf(FactoryTestUser::class, $users->first()); + + $users = FactoryTestUserFactory::times(2)->createMany(); + $this->assertInstanceOf(Collection::class, $users); + $this->assertCount(2, $users); + $this->assertInstanceOf(FactoryTestUser::class, $users->first()); + + $users = FactoryTestUserFactory::times(3)->createMany([ + ['name' => 'Taylor Otwell'], + ['name' => 'Jeffrey Way'], + ]); + $this->assertInstanceOf(Collection::class, $users); + $this->assertCount(2, $users); + $this->assertInstanceOf(FactoryTestUser::class, $users->first()); $users = FactoryTestUserFactory::new()->createMany(); $this->assertInstanceOf(Collection::class, $users); $this->assertCount(1, $users); + $this->assertInstanceOf(FactoryTestUser::class, $users->first()); $users = FactoryTestUserFactory::times(10)->create(); $this->assertCount(10, $users); From 91e2b9e218afa4e5c377510faa11957042831ba3 Mon Sep 17 00:00:00 2001 From: driesvints Date: Tue, 30 Apr 2024 12:52:59 +0000 Subject: [PATCH 09/16] Update version to v10.48.10 --- src/Illuminate/Foundation/Application.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Illuminate/Foundation/Application.php b/src/Illuminate/Foundation/Application.php index 780e03b81f8f..f419828c6430 100755 --- a/src/Illuminate/Foundation/Application.php +++ b/src/Illuminate/Foundation/Application.php @@ -40,7 +40,7 @@ class Application extends Container implements ApplicationContract, CachesConfig * * @var string */ - const VERSION = '10.48.9'; + const VERSION = '10.48.10'; /** * The base path for the Laravel installation. From 1de31568c504cb284e7ed81fab77ec84601dd509 Mon Sep 17 00:00:00 2001 From: Dries Vints Date: Tue, 30 Apr 2024 15:11:49 +0200 Subject: [PATCH 10/16] wip --- .github/workflows/releases.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml index 359877d89f72..7f64247091d9 100644 --- a/.github/workflows/releases.yml +++ b/.github/workflows/releases.yml @@ -90,10 +90,11 @@ jobs: - name: Cleanup release notes id: cleaned-notes run: | - NOTES="${{ steps.generated-notes.outputs.release-notes }}" - NOTES=$(echo $NOTES | sed '/## What/d') - NOTES=$(echo $NOTES | sed '/## New Contributors/,$d') - echo "release-notes=${NOTES}" >> "$GITHUB_OUTPUT" + RELEASE_NOTES=$(echo $NOTES | sed '/## What/d') + RELEASE_NOTES=$(echo $RELEASE_NOTES | sed '/## New Contributors/,$d') + echo "release-notes=${RELEASE_NOTES}" >> "$GITHUB_OUTPUT" + env: + NOTES: ${{ steps.generated-notes.outputs.release-notes }} - name: Create release uses: softprops/action-gh-release@v2 From 5ae8fa0d6576a78f8be6003a0a0439f25e40361a Mon Sep 17 00:00:00 2001 From: Dries Vints Date: Tue, 30 Apr 2024 15:27:08 +0200 Subject: [PATCH 11/16] wip --- .github/workflows/releases.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml index 7f64247091d9..39891d4db11c 100644 --- a/.github/workflows/releases.yml +++ b/.github/workflows/releases.yml @@ -90,9 +90,9 @@ jobs: - name: Cleanup release notes id: cleaned-notes run: | - RELEASE_NOTES=$(echo $NOTES | sed '/## What/d') - RELEASE_NOTES=$(echo $RELEASE_NOTES | sed '/## New Contributors/,$d') - echo "release-notes=${RELEASE_NOTES}" >> "$GITHUB_OUTPUT" + NOTES=$(echo $NOTES | sed '/## What/d') + NOTES=$(echo $NOTES | sed '/## New Contributors/,$d') + echo "release-notes=${NOTES}" >> "$GITHUB_OUTPUT" env: NOTES: ${{ steps.generated-notes.outputs.release-notes }} From 470e3e8723b4155a00ca743e57780560bad3b0d9 Mon Sep 17 00:00:00 2001 From: Dries Vints Date: Tue, 30 Apr 2024 15:28:25 +0200 Subject: [PATCH 12/16] update changelog --- CHANGELOG.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 63f2cbfeda66..d5d03da62763 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,12 @@ # Release Notes for 10.x -## [Unreleased](https://github.com/laravel/framework/compare/v10.48.9...10.x) +## [Unreleased](https://github.com/laravel/framework/compare/v10.48.10...10.x) + +## [v10.48.10](https://github.com/laravel/framework/compare/v10.48.9...v10.48.10) - 2024-04-30 + +* [10.x] Fix typo in signed URL tampering tests by @Krisell in https://github.com/laravel/framework/pull/51238 +* [10.x] Add "Server has gone away" to DetectsLostConnection by @Jubeki in https://github.com/laravel/framework/pull/51241 +* [10.x] Fix support for the LARAVEL_STORAGE_PATH env var (#51238) by @dunglas in https://github.com/laravel/framework/pull/51243 ## [v10.48.9](https://github.com/laravel/framework/compare/v10.48.8...v10.48.9) - 2024-04-23 From e090ee638ebd4ce221d8bad43b49bbf59ea70ae5 Mon Sep 17 00:00:00 2001 From: driesvints Date: Tue, 30 Apr 2024 13:30:08 +0000 Subject: [PATCH 13/16] Update version to v11.6.0 --- src/Illuminate/Foundation/Application.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Illuminate/Foundation/Application.php b/src/Illuminate/Foundation/Application.php index 7684c9acc40b..b9ce4a9598a2 100755 --- a/src/Illuminate/Foundation/Application.php +++ b/src/Illuminate/Foundation/Application.php @@ -45,7 +45,7 @@ class Application extends Container implements ApplicationContract, CachesConfig * * @var string */ - const VERSION = '11.5.0'; + const VERSION = '11.6.0'; /** * The base path for the Laravel installation. From 9d502965cb542b272573a22083524b120bc06643 Mon Sep 17 00:00:00 2001 From: driesvints Date: Tue, 30 Apr 2024 13:31:34 +0000 Subject: [PATCH 14/16] Update CHANGELOG --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e5e8e5e72290..6b5d150f3c85 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ # Release Notes for 11.x -## [Unreleased](https://github.com/laravel/framework/compare/v11.5.0...11.x) +## [Unreleased](https://github.com/laravel/framework/compare/v11.6.0...11.x) + +## [v11.6.0](https://github.com/laravel/framework/compare/v11.5.0...v11.6.0) - 2024-04-30 ## [v11.5.0](https://github.com/laravel/framework/compare/v11.4.0...v11.5.0) - 2024-04-23 From da4044d50823d2491ca2b8dd525601fd0bf09083 Mon Sep 17 00:00:00 2001 From: Dries Vints Date: Tue, 30 Apr 2024 15:33:20 +0200 Subject: [PATCH 15/16] Update CHANGELOG.md --- CHANGELOG.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6b5d150f3c85..90b57fa46084 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,20 @@ ## [v11.6.0](https://github.com/laravel/framework/compare/v11.5.0...v11.6.0) - 2024-04-30 +* [11.x] github: mariadb database healthcheck+naming by @grooverdan in https://github.com/laravel/framework/pull/51192 +* Add support for PHPUnit 11.1 by @crynobone in https://github.com/laravel/framework/pull/51197 +* Move whitespace in front of verbatim block in Blade templates by @Sjord in https://github.com/laravel/framework/pull/51195 +* [11.x] Trim trailing `?` from generated URL without query params by @onlime in https://github.com/laravel/framework/pull/51191 +* Add some tests on route:list sort command by @fgaroby in https://github.com/laravel/framework/pull/51202 +* [10.x] Improve releases flow by @driesvints in https://github.com/laravel/framework/pull/51213 +* Fix return types of `firstWhere` and `first` of `BelongsToMany` and `HasManyThrough` by @SanderMuller in https://github.com/laravel/framework/pull/51219 +* [10.x] Fix typo in signed URL tampering tests by @Krisell in https://github.com/laravel/framework/pull/51238 +* [10.x] Add "Server has gone away" to DetectsLostConnection by @Jubeki in https://github.com/laravel/framework/pull/51241 +* [11.x] Add some tests in `SupportStrTest` class by @saMahmoudzadeh in https://github.com/laravel/framework/pull/51235 +* [10.x] Fix support for the LARAVEL_STORAGE_PATH env var (#51238) by @dunglas in https://github.com/laravel/framework/pull/51243 +* [11.x] Add replaceable tags to translations by @LegendEffects in https://github.com/laravel/framework/pull/51190 +* [10.x] fix: Factory::createMany creating n^2 records by @calebdw in https://github.com/laravel/framework/pull/51225 + ## [v11.5.0](https://github.com/laravel/framework/compare/v11.4.0...v11.5.0) - 2024-04-23 * [11.x] Add namespace for `make:trait` and `make:interface` command by [@milwad-dev](https://github.com/milwad-dev) in https://github.com/laravel/framework/pull/51083 From a57dca1b039b02fca8a517f6df40f757009d2b86 Mon Sep 17 00:00:00 2001 From: Dries Vints Date: Tue, 30 Apr 2024 15:42:57 +0200 Subject: [PATCH 16/16] wip --- .github/workflows/releases.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml index 39891d4db11c..8dcfa62b65c0 100644 --- a/.github/workflows/releases.yml +++ b/.github/workflows/releases.yml @@ -18,7 +18,7 @@ jobs: outputs: version: ${{ steps.version.outputs.version }} - notes: ${{ steps.cleaned-notes.outputs.release-notes }} + notes: ${{ steps.cleaned-notes.outputs.notes }} steps: - name: Checkout repository @@ -90,11 +90,11 @@ jobs: - name: Cleanup release notes id: cleaned-notes run: | - NOTES=$(echo $NOTES | sed '/## What/d') - NOTES=$(echo $NOTES | sed '/## New Contributors/,$d') - echo "release-notes=${NOTES}" >> "$GITHUB_OUTPUT" + RELEASE_NOTES=$(echo $RELEASE_NOTES | sed '/## What/d') + RELEASE_NOTES=$(echo $RELEASE_NOTES | sed '/## New Contributors/,$d') + echo "notes=${RELEASE_NOTES}" >> "$GITHUB_OUTPUT" env: - NOTES: ${{ steps.generated-notes.outputs.release-notes }} + RELEASE_NOTES: ${{ steps.generated-notes.outputs.release-notes }} - name: Create release uses: softprops/action-gh-release@v2 @@ -103,7 +103,7 @@ jobs: with: tag_name: v${{ steps.version.outputs.version }} name: v${{ steps.version.outputs.version }} - body: ${{ steps.cleaned-notes.outputs.release-notes }} + body: ${{ steps.cleaned-notes.outputs.notes }} target_commitish: ${{ github.ref_name }} make_latest: 'legacy'