Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TamperSheetGesture and related classes as public APIs #242

Open
river2202 opened this issue Sep 16, 2024 · 1 comment
Open

Expose TamperSheetGesture and related classes as public APIs #242

river2202 opened this issue Sep 16, 2024 · 1 comment
Assignees
Labels
feature request New feature or request P3
Milestone

Comments

@river2202
Copy link

First thanks for open source this great package!

And I have seems some API marking as "TODO: Expose this as a public API.", eg what we need is the swipe down to dismiss to be working for more draggable sheet. Make TamperSheetGesture related API public will create help and make package more extendable.

It seems like it is a quick win to just remove the @internal, is there any timeline to release this?

@fujidaiti fujidaiti self-assigned this Sep 19, 2024
@fujidaiti fujidaiti added feature request New feature or request P3 labels Sep 19, 2024
@fujidaiti fujidaiti added this to the stable milestone Sep 19, 2024
@fujidaiti fujidaiti changed the title Plan for "TODO: Expose this as a public API"? Expose TamperSheetGesture and related classes as public APIs Sep 19, 2024
@fujidaiti
Copy link
Owner

fujidaiti commented Sep 19, 2024

Hi @river2202,

I've omitted them from the public APIs mainly due to the lack of documentation and examples.

is there any timeline to release this?

I'm currently focused on bug fixes related to the on-screen keyboard, so it won't be released soon. However, I'll work on this task before the first stable release.

What we need is the swipe down to dismiss to be working for more draggable sheet.

Could you explain in more detail what you're trying to achieve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request P3
Projects
None yet
Development

No branches or pull requests

2 participants