Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseComponent for CancellationToken handling #197

Open
modersohn opened this issue Jun 26, 2022 · 0 comments
Open

BaseComponent for CancellationToken handling #197

modersohn opened this issue Jun 26, 2022 · 0 comments

Comments

@modersohn
Copy link
Collaborator

Currently the extra code for proper CancellationToken handling is copied e.g. in AccountDetails but also in NFTGrid and a lot of pages don't support it at all (but should!).

The idea is to move this into an ancestor component that provides a new overridable method (e.g. OnParametersSetAsyncWithCTS) that is called after CTS allocation has been done and before it cleans up.

It's not ideal OOP as descendants need to know they need to override the new method instead of OnParametersSetAsync, but I currently don't see a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant