Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enabling mint without int #166

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix enabling mint without int #166

merged 1 commit into from
Dec 11, 2023

Conversation

sjb3d
Copy link
Contributor

@sjb3d sjb3d commented Dec 11, 2023

This PR fixes a minor issue in #163 where mint conversions are added for integer types, but without checking that the int feature is enabled.

This leads to compile errors if mint is enabled without int. With the changes in this PR, the two features can be enabled independently again (tested in a local project that only enables mint).

(No changelog entry since there has not yet been a release with these additional conversions.)

@fu5ha
Copy link
Owner

fu5ha commented Dec 11, 2023

Ah, nice catch :)

@fu5ha fu5ha merged commit 05a0d94 into fu5ha:main Dec 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants