Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject break statements outside loops #70

Closed
fstirlitz opened this issue Aug 18, 2019 · 2 comments
Closed

Reject break statements outside loops #70

fstirlitz opened this issue Aug 18, 2019 · 2 comments
Assignees
@fstirlitz
Labels
incorrect parsing Valid Lua code fails to parse, is parsed incorrectly, or invalid Lua code is accepted
Milestone
0.3

Comments

@fstirlitz
Copy link
Owner

There is a disabled expected-failure testcase in the test/scaffolding/functions file:

function a(p) break end                 -- FAIL

Currently, it parses successfully; although it matches the basic recursive grammar, it semantically makes no sense and is rejected by all Lua implementations at compilation stage (although apparently only after the entire body is parsed). It would probably make sense to reject it here too.
@fstirlitz fstirlitz added the incorrect parsing Valid Lua code fails to parse, is parsed incorrectly, or invalid Lua code is accepted label Aug 18, 2019
@fstirlitz fstirlitz self-assigned this Aug 21, 2019
@fstirlitz
Copy link
Owner Author

I've got some WIP code which fixes this.

@fstirlitz fstirlitz mentioned this issue Oct 5, 2019
Closed
@fstirlitz fstirlitz added this to the 0.3 milestone Oct 5, 2019
@fstirlitz
Copy link
Owner Author

Fixed in 680238c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fstirlitz fstirlitz

Labels
incorrect parsing Valid Lua code fails to parse, is parsed incorrectly, or invalid Lua code is accepted
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@fstirlitz