Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fantomas with dotnet-format #430

Closed
cartermp opened this issue Mar 28, 2019 · 3 comments
Closed

Using fantomas with dotnet-format #430

cartermp opened this issue Mar 28, 2019 · 3 comments

Comments

@cartermp
Copy link

We'd like to pull in a dependency on Fantomas for the dotnet-format tool (tracking issue: dotnet/format#39).

Technically it would be straightforward to do, since the tool just does some orchestration of the C# and VB code formatters today, and it would just shell out to Fantomas when encountering F# projects. But there is a question on policy, which I propose as follows:

  • Issues for F# formatting are moved to this repo
  • Since Fantomas is an OSS project, there is no support policy that either Microsoft or Fantomas maintainers must adhere to

Thoughts? cc @jmarolf

@jindraivanek
Copy link
Contributor

If I read that policy correctly, it doesn't mean any change for us, so no reason to disagree with that.

It would be great if new F# formatting issues would be created through http://ratatosk.dynu.net/fantomas site.

@jmarolf
Copy link

jmarolf commented Mar 29, 2019

@jindraivanek sounds great! Just wanted to make sure it was fine to package fantomas inside another global tool. I'll make sure that people posting on the dotnet/format repo know to file bugs on http://ratatosk.dynu.net/fantomas if they are fantomas specific

@cartermp
Copy link
Author

The main thing is it may be reasonable to expect more bugs coming in as this does open up fantomas to more use. Just wanted to make sure that was okay 🙂

I'll close the issue as we'll take care of thing on the dotnet-format side. Let us know if you have any further questions/concerns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants