Stroustrup record type definition with access modifiers and members lead to invalid F# code

[sergey-tihon]

Issue created from fantomas-online

Code

type NonEmptyList<'T> =
    private
        { List: 'T list }

    member this.Head = this.List.Head
    member this.Tail = this.List.Tail
    member this.Length = this.List.Length

Result

type NonEmptyList<'T> =
    private {
        List: 'T list
    }

member this.Head = this.List.Head
member this.Tail = this.List.Tail
member this.Length = this.List.Length

Problem description

Please describe here the Fantomas problem you encountered.
Check out our Contribution Guidelines.

Extra information

• The formatted result breaks my code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.

Options

Fantomas master branch at 2022-09-17T05:39:07Z - c1a99d4

    { config with
                MultilineBlockBracketsOnSameColumn = true
                ExperimentalStroustrupStyle = true }

_{Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?}

[nojaf]

Hello, I believe this problem was introduced after #2484.
You would need to tighten the condition that there are no members.

Changing ifStroustrupElse (opt (sepSpace) ao' genAccess) (opt (indent +> sepNln) ao' genAccess) to something like:

(fun ctx -> 
    if ctx.Config.ExperimentalStrouStrup && List.isEmpty ms then
        (opt (sepSpace) ao' genAccess) ctx
    else
        (opt (indent +> sepNln) ao' genAccess) ctx)

I haven't tested this code, but that might do the trick.

Are you interested in submitting a PR?

[sergey-tihon]

@josh-degraw Thank you for opening PR with the fix for this!