Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mishandling of comment #247

Closed
SteveGilham opened this issue May 7, 2018 · 3 comments
Closed

Mishandling of comment #247

SteveGilham opened this issue May 7, 2018 · 3 comments

Comments

@SteveGilham
Copy link

Applying fantomas 2.7.1 to https://github.com/SteveGilham/altcover/blob/f1aa1e0a4a80a62abd5c07adf8f337fd0da025c6/AltCover/Runner.fs, the comment on line 638 ends up in a completely different part of the code (what was line 484), causing a build break, like this

                       match x.// And tidy up after everything's done
                               Name with
@jindraivanek
Copy link
Contributor

This is comments integrate bug.

There is also wrongly placed comment before that one:

                interleave
                |> Seq.fold (fun (bev, // mocking points
                                       sq : XmlElement) x -> 
                       match x.// And tidy up after everything's done
                               Name with

Something in formatted code at this point or before it put comment integrate alg out of sync.

@kellerd
Copy link

kellerd commented May 16, 2018

Another reproduction: requires an identifier and negative counting range initialization

Code:

let test n = [ n..-1..1 ]
let y = ()
// Some comments

Becomes:

let test n = [ n.// Some Comments
                 .-1..1 ]
let y = ()

@nojaf
Copy link
Contributor

nojaf commented Jan 23, 2019

Could not reproduce anymore online.

Please re-open if still a problem.

@nojaf nojaf closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants