Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global namespace should not be escaped #2366

Closed
1 of 3 tasks
MangelMaxime opened this issue Jul 15, 2022 · 3 comments · Fixed by #2385
Closed
1 of 3 tasks

global namespace should not be escaped #2366

MangelMaxime opened this issue Jul 15, 2022 · 3 comments · Fixed by #2385

Comments

@MangelMaxime
Copy link

Issue created from fantomas-online

Code

namespace Ionide.VSCode.FSharp

open global.Node

Result

namespace Ionide.VSCode.FSharp

open `global`.Node

Problem description

Fantomas should not change global

Extra information

  • The formatted result breaks my code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas master branch at 2022-07-15T14:30:45Z - 87cd212

    { config with
                MaxIfThenElseShortWidth = 40
                MaxInfixOperatorExpression = 50
                MaxArrayOrListWidth = 40
                MaxDotGetExpressionWidth = 50
                NewlineBetweenTypeDefinitionAndMembers = false }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

@nojaf
Copy link
Contributor

nojaf commented Jul 18, 2022

Hello, thanks for reporting this.
It is exactly the kind of feedback I want to address before we can call v5 stable.
This fix will require a change on the compiler side, one I have been postponing for a bit.
Time to finally bite the bullet.

@nojaf nojaf linked a pull request Jul 26, 2022 that will close this issue
@nojaf nojaf mentioned this issue Jul 26, 2022
@nojaf
Copy link
Contributor

nojaf commented Jul 26, 2022

Hello @MangelMaxime, I released this fix in v5-beta-003.

@MangelMaxime
Copy link
Author

Hello @nojaf,

I confirm that I cannot reproduce it using Ionide repo. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants