Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a better error message when the folder does not exist #2341

Closed
nojaf opened this issue Jul 7, 2022 · 0 comments · Fixed by #2384
Closed

Show a better error message when the folder does not exist #2341

nojaf opened this issue Jul 7, 2022 · 0 comments · Fixed by #2384
Labels
enhancement good first issue Long hanging fruit: easy issue to get your feet wet!

Comments

@nojaf
Copy link
Contributor

nojaf commented Jul 7, 2022

When you run dotnet fantomas right now, you get the Input path is missing... message.
Is that a good message or should the help be shown instead?

Next, if you run dotnet fantomas foo where the folder foo doesn't exist, you get that same Input path is missing... message. This could be improved by No file or folder "foo" found on disk or something similar.

I recall an example where a path with Windows slashes was used on a Linux VM using the --check flag and it wasn't all that obvious that nothing happened.
The exit code is also 0 when you enter dotnet fantomas foo --check ; $LASTEXITCODE (in PowerShell).
This should be 1 as it is without the --check flag.

@nojaf nojaf added enhancement good first issue Long hanging fruit: easy issue to get your feet wet! labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Long hanging fruit: easy issue to get your feet wet!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant