Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global keywordis escaped with single-backticks when used as part of a namespace/module open #2274

Closed
2 of 3 tasks
baronfel opened this issue May 23, 2022 · 1 comment · Fixed by #2385
Closed
2 of 3 tasks

Comments

@baronfel
Copy link
Contributor

Issue created from fantomas-online

Code

[<CompilationRepresentation(CompilationRepresentationFlags.ModuleSuffix)>]
module Ionide.VSCode.FSharp

open global.Node.ChildProcess

Result

[<CompilationRepresentation(CompilationRepresentationFlags.ModuleSuffix)>]
module Ionide.VSCode.FSharp

open `global`.Node.ChildProcess

Problem description

Please describe here the Fantomas problem you encountered.
Check out our Contribution Guidelines.

Extra information

  • The formatted result breaks my code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas master branch at 2022-05-20T08:43:30Z - 5fdc87d

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

@nojaf
Copy link
Contributor

nojaf commented May 23, 2022

Looks like SynOpenDeclTarget.ModuleOrNamespace should a have SynLongIdent instead of LongIdent for the longId.

We took that global straight from the AST, which should have a IdentTrivia.
Cleanest way of fixing this would be at the compiler side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants