Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the FormatSelection public API #2237

Closed
nojaf opened this issue May 7, 2022 · 0 comments · Fixed by #2272
Closed

Restore the FormatSelection public API #2237

nojaf opened this issue May 7, 2022 · 0 comments · Fixed by #2272
Labels
v5

Comments

@nojaf
Copy link
Contributor

nojaf commented May 7, 2022

While processing the many changes of #2217, the CodeFormatter.FormatSelection API was broken.

This part of the codebase hasn't been touched since Ahn left the project and should probably be revisited from scratch. Given the complexity of this matter, this might not make it for the v5.0 stable release,
and could be restored later in the 5.x series.
@nojaf nojaf added the v5 label May 7, 2022
@nojaf nojaf linked a pull request Jun 27, 2022 that will close this issue
Format selection #2272
Merged
5 tasks
@nojaf nojaf closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format selection nojaf/fantomas
1 participant
@nojaf