Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linq method call breaks because of space before paren lambda was added #2231

Closed
2 of 3 tasks
dawedawe opened this issue May 6, 2022 · 0 comments · Fixed by #2232
Closed
2 of 3 tasks

Linq method call breaks because of space before paren lambda was added #2231

dawedawe opened this issue May 6, 2022 · 0 comments · Fixed by #2232

Comments

@dawedawe
Copy link
Member

dawedawe commented May 6, 2022

Issue created from fantomas-online

Formatted code

open System.Linq

type Item() =
    member val ValidFrom = DateTime.MinValue
    member val Value = 23.42m

let items = [ Item(); Item(); Item() ]

let firstOrDef =
    items.FirstOrDefault (fun x ->
        x.ValidFrom <= DateTime.Now
        || x.ValidFrom > DateTime.Now)
        .Value

Reformatted code

open System.Linq

type Item() =
    member val ValidFrom = DateTime.MinValue
    member val Value = 23.42m

let items = [ Item(); Item(); Item() ]

let firstOrDef =
    items.FirstOrDefault
        (fun x ->
            x.ValidFrom <= DateTime.Now
            || x.ValidFrom > DateTime.Now)
            .Value

Problem description

Fantomas was not able to produce the same code after reformatting the result.
Yes, there is an idempotency issue here, but it also breaks the code of linq method calls.

Extra information

  • The formatted result breaks my code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas master branch at 2022-05-04T06:20:06Z - 0e036ac

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants