Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping exact FCS version #2118

Closed
nojaf opened this issue Feb 28, 2022 · 4 comments · Fixed by #2119
Closed

Ping exact FCS version #2118

nojaf opened this issue Feb 28, 2022 · 4 comments · Fixed by #2119
Labels
enhancement

Comments

@nojaf
Copy link
Contributor

nojaf commented Feb 28, 2022

In the latest release we claim that we need FCS 41.0.1 or higher:
image

This is not the case though, Fantomas will only support one exact FCS version (being 41.0.1 in this case).

Do you agree with pinning this version @baronfel?
@baronfel
Copy link
Contributor

Yeah, though we should push for greater reliability on the versions of FCS published from dotnet/fsharp to help prevent these kinds of mixups.

@nojaf
Copy link
Contributor Author

nojaf commented Mar 2, 2022

Interestingly enough, we seem to already specify an exact version in the paket.dependencies file:

fantomas/paket.dependencies

Line 7 in 17e6b45

nuget FSharp.Compiler.Service 41.0.1

@nojaf
Copy link
Contributor Author

nojaf commented Mar 2, 2022

Another somewhat related thing:
image

Fantomas.Extras should also depend on the exact same version of Fantomas.
This constraint is also wrong.

@nojaf
Copy link
Contributor Author

nojaf commented Mar 2, 2022

That last one seems related to NuGet/Home#5525.

@nojaf nojaf mentioned this issue Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lock FCS version in Fantomas nuspec nojaf/fantomas
2 participants
@baronfel @nojaf