Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running fake build locally #2056

Closed
nojaf opened this issue Feb 1, 2022 · 0 comments · Fixed by #2066
Closed

Running fake build locally #2056

nojaf opened this issue Feb 1, 2022 · 0 comments · Fixed by #2066

Comments

@nojaf
Copy link
Contributor

nojaf commented Feb 1, 2022

The contribution guidelines don't really mention our build pipeline that much.
People who are preparing a PR should at least locally run dotnet fake build to verify that their code works before submitting a PR.
Some people forget to format the new code for example. We should cover stuff like this in https://github.com/fsprojects/fantomas/blob/master/CONTRIBUTING.md#guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant