Regression of #502: Pattern match bodies no longer indented sufficiently for shorter indentation sizes

[cmeeren]

Issue created from fantomas-online

Expected result

match x with
| "1" ->
    longLineLongLineLongLineLongLineLongLineLongLineLongLineLongLineLongLine
| "2" ->
    longLineLongLineLongLineLongLineLongLineLongLineLongLineLongLineLongLine

Actual result

match x with
| "1" ->
  longLineLongLineLongLineLongLineLongLineLongLineLongLineLongLineLongLine
| "2" ->
  longLineLongLineLongLineLongLineLongLineLongLineLongLineLongLineLongLine

Problem description

There has been a regression where pattern matching bodies are no longer indented sufficiently for shorter indentation sizes (e.g. 2 spaces). This was originally implemented/fixed in #502. I don't know when the regression happened.

The extra indentation is useful for better separation of patterns vs. the "body" of each pattern. The problem does not exist for 4-space indentation.

Extra information

• The formatted result breaks by code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.

Options

Fantomas 4.6 branch at 09/08/2021 16:41:29 - 9bf6601

    { config with
                IndentSize = 2
                MaxLineLength = 80 }

[nojaf]

This was updated in #1501 to align with the style guide.
The codebase also benefitted from this correction.

[cmeeren]

Ah, I thought the style guide covered this. I have created dotnet/docs#26071 to try and rectify this, so we 2-space-indenters can get sufficient visual separation between the clauses and the bodies. 🙂