-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feliz-style formatting #1225
Comments
Hello, this feature suggestion violates our Contribution Guidelines and falls under the section What are we not looking for?. Fantomas has two styles of formatting records and this third one would imply massive changes over the entire codebase. I have no interest in maintaining this and wish to stick to what is listed in the styles guides. Please read the Contribution Guidelines carefully to understand why I'm closing this. |
@nojaf Thanks for the explanation and a working link to the contributor guidelines. - the one in the issue template is broken and leads to a 404. |
Thanks for pointing that out, created #1246 |
Update: Already implemented with This is an issue for me for the same reason. Feliz is the standard library for React rendering in Fable. Both the extra horizontal cadence of |
hello, i would need this working also for Feliz.ViewEngine, what settings do i need to specify? |
In #453, @ForNeVeR and @blumu asked for a style as follows (from aforementioned issue):
This also corresponds to the default Feliz formatting (https://zaid-ajaj.github.io/Feliz/):
This is a style I see in a lot of open source projects and that's why we've adopted the style for all our projects too. While there have been follow-ups to other points from #453, I didn't see any on this.
In comparison with other styles:
In my personal opinion, the style above is a nice compromise between the two, which might also be the reason why it's often seen even without any tooling support for it. As I believe I'm not the only one in favor of this style, a config option to enable this formatting similar to the multiline block one would allow us to adopt Fantomas into our CI pipeline and greatly improve our F# dev experience.
I propose we extend Fantomas to support this style.
Pros and Cons
The advantages of making this adjustment to Fantomas are
The disadvantages of making this adjustment to Fantomas are that it's probably a non-trivial change.
Examples
See #453
Extra information
Estimated cost (XS, S, M, L, XL, XXL): Unsure, maybe L - XL?
Affidavit (please submit!)
Please tick this by placing a cross in the box:
Please tick all that apply:
The text was updated successfully, but these errors were encountered: