Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack command doesn't escape filenames correctly (mark 2) #975

Closed
jamescrowley opened this issue Aug 12, 2015 · 2 comments
Closed

Pack command doesn't escape filenames correctly (mark 2) #975

jamescrowley opened this issue Aug 12, 2015 · 2 comments

Comments

@jamescrowley
Copy link

While #959 resolved issues with spaces, it also unnecessarily encodes parenthesis, which again results in files being missed when installing a nupkg. Need to review the NuGet spec more closely here, as there may be differences between folders and files in how they should be encoded.
@forki
Copy link
Member

forki commented Aug 12, 2015

Sigh. Could you please send a pull request? I already added a post replacement.

@forki
Copy link
Member

forki commented Aug 13, 2015

I think the twitter response https://twitter.com/emgarten/status/631571367083675648 doesn't help ;-)

@will14smith will14smith mentioned this issue Aug 19, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @jamescrowley