-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket pack: Duplicate files being archived when specified multiple times in templates #851
Labels
Comments
4e2547a should do the trick |
Hmm, the problem still reproduces with 1.9.2. |
ah found another thingy |
could you please try 1.9.3 - looks good for me |
It seems to be working, however now the net40 files have disappeared from the archive - as if the files in the template are being completely ignored. |
Ok, so I ran clean/reset in my local repo and everything seems to be working fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I came across an issue where files being specified more than once result in the same file being included multiple times in the nupkg archive. The behaviour can be reproduced using this commit. For instance, In FsPickler.fsproj, the paket template contains the following declarations:
This will cause the
net45
FsPickler.dll to be bundled twice, but not the same fornet40
.The obvious fix here would be to omit the net45 declarations, but I would prefer the explicitness of the current version.
Taking this issue to the extreme, it is possible to do the following:
which yields the following result:
The text was updated successfully, but these errors were encountered: