Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update GitHub dependency #385

Closed
tpluscode opened this issue Nov 23, 2014 · 8 comments
Closed

Cannot update GitHub dependency #385

tpluscode opened this issue Nov 23, 2014 · 8 comments

Comments

@tpluscode
Copy link
Contributor

Once there is a github dependency downloaded into paket-files it's not possible to update.

To reproduce:

  1. Clone https://github.com/tpluscode/paket-dependencies/
  2. paket update
  3. Get error File "[...]\paket-files\tpluscode\fileversionextractor\.gitattributes" already exists.
@forki
Copy link
Member

forki commented Nov 23, 2014

works for me

image

seems there is something else going on.

(We are doing updates with github dependencies in a couple of projects multiple times a day)

@tpluscode
Copy link
Contributor Author

Hm. Have you pulled latest from GitHub? Earlier the paket-files weren't checked-in.

@forki
Copy link
Member

forki commented Nov 23, 2014

Yes I tested on 0502edf30ba168605c3a3ce6adfbffb84db0674a

@tpluscode
Copy link
Contributor Author

That's strange then. Maybe the code could be made more robust anyway. How is updating GitHub dependecies implemented? Such error that I get would not be possible if entire folder was removed first.

@forki
Copy link
Member

forki commented Nov 23, 2014

if entire folder was removed first.

we are doing this, but before we're checking if the folder is up-to-date (to save your bandwidth).

It would be really interesting to reproduce this.

@tpluscode
Copy link
Contributor Author

Oh bugger, sorry my bad, I forgot to push after all. Please try again now with revision 1ea188a472

@forki
Copy link
Member

forki commented Nov 23, 2014

cool I can reproduce and will try to find the issue. 👍

@forki forki closed this as completed in 34e9d4e Nov 23, 2014
@tpluscode
Copy link
Contributor Author

It works. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants