Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket.Core packaged incorrectly #3413

Open
matthid opened this issue Nov 10, 2018 · 2 comments
Open

Paket.Core packaged incorrectly #3413

matthid opened this issue Nov 10, 2018 · 2 comments

Comments

@matthid
Copy link
Member

matthid commented Nov 10, 2018

After fixing #2792 it is still broken:
image

I think there is also some other issue which breaks fake fsprojects/FAKE#2192
I'm trying to figure out what's going on and update this post
/cc @enricosada who might have an idea about the recent package changes which might introduce this break.

@matthid
Copy link
Member Author

matthid commented Nov 10, 2018

Ok the problem is indeed this:
image

I don't think this is actually what we want. It feels like a design problem in Paket that we have < 4.5 in the deps file but use the same restriction in the final package. This is definitely NOT AT ALL what you want for libraries.

@forki @enricosada any idea how to fix that design issue?

@matthid
Copy link
Member Author

matthid commented Nov 10, 2018

I could hack paket.lock for now as a workaround but I'm afraid that this completely breaks dotnet-fake as the <4.5 requirement is probably inherited to fake.runtime -> dotnet-fake. But I'll try anyway and hope for the best ...

@forki forki closed this as completed in c51f5f3 Nov 13, 2018
@matthid matthid reopened this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant