Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything works! #2523

Closed
0x53A opened this issue Jul 14, 2017 · 6 comments
Closed

Everything works! #2523

0x53A opened this issue Jul 14, 2017 · 6 comments

Comments

@0x53A
Copy link
Contributor

0x53A commented Jul 14, 2017

ref dotnet/fsharp#3335

@forki
Copy link
Member

forki commented Jul 14, 2017

This is a vs issue. Please report over there. I think it works in ionide.

@forki forki closed this as completed Jul 14, 2017
@forki forki reopened this Jul 14, 2017
@forki
Copy link
Member

forki commented Jul 14, 2017

We should keep it still open until both sides fit together.

/cc @enricosada @cartermp

@Krzysztof-Cieslak
Copy link
Member

Krzysztof-Cieslak commented Jul 14, 2017

If it works in Ionide and MsBuild (dotnet CLI) then it's working fine. VS not following specification was exact core of the problem with old project files, let's not repeat this mistake again ;]

@0x53A
Copy link
Contributor Author

0x53A commented Jul 14, 2017

I assume it is an issue in the F# implementation of Microsoft.NET.Sdk.

dotnet/fsharp#3335

The equivalent C# project does work without issues:

<Project Sdk="Microsoft.NET.Sdk">
  
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  
  <Import Project="..\.paket\Paket.Restore.targets" />
  
</Project> 

image

@0x53A 0x53A changed the title newsdk + paket only loads in VS with FSharp.NET.Sdk [external @VF#] newsdk + paket only loads in VS with FSharp.NET.Sdk Jul 14, 2017
@0x53A
Copy link
Contributor Author

0x53A commented Jul 14, 2017

@forki @Krzysztof-Cieslak hm, seems like build also does not work.

Can you please test https://github.com/0x53A/dotnet-tests/tree/fsharp+paket if you get the same results? Mine are in readme.md.


Since C# works, I still think the issue is with the F# part of Microsoft.NET.Sdk, but maybe there is a workaround paket could implement.

@0x53A
Copy link
Contributor Author

0x53A commented Jul 15, 2017

image

@0x53A 0x53A closed this as completed Jul 15, 2017
@0x53A 0x53A changed the title [external @VF#] newsdk + paket only loads in VS with FSharp.NET.Sdk Everything works! Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants