Paket install enters an endless loop

[thingylab]

Description

paket install and paket update started hanging while looking for a specific package hosted on a local artifactory (version = 4.6.0).

Repro steps

I do not have specific steps to reproduce the issue as other packages hosted on the same artifactory server work just fine.
This being said, on close inspection it appeared the followODataLink function (in NuGetV2.fs) entered an endless loop. In effect the behavior was:

let rec followODataLink inputUrl =
    let data = fetchData inputUrl
    let urls = extractUrlsFromData
    let res = List.map followODataLink urls
    
    [do some other stuff here]

It appears in my case inputUrl was included in the resulting urls, sending the function into an infinite loop.

Expected behavior

paket install finishing in finite time

Actual behavior

Endless loop.

Known workarounds

Filter out the input url from the recursive calls. See this PR.