Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New year's updates #226

Merged
merged 3 commits into from
Jan 13, 2023
Merged

New year's updates #226

merged 3 commits into from
Jan 13, 2023

Conversation

CaptnCodr
Copy link
Member

@CaptnCodr CaptnCodr commented Jan 6, 2023

As mentioned in #225:

  • Align should & throw.
  • Compile for .NET7.
  • Update copyright strings.
  • Update dependencies.

@CaptnCodr
Copy link
Member Author

Those two build failed with the same message as here: fsprojects/FAKE#2719
I'll let it at version 5.23.1 and wait for FAKE 6 ...

@CaptnCodr CaptnCodr requested a review from sergey-tihon January 9, 2023 06:45
Copy link
Member

@sergey-tihon sergey-tihon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaptnCodr thank you for this change. I am OK with this change, but what is the benefit of providing assemblies for .NET 7 ?

@CaptnCodr
Copy link
Member Author

CaptnCodr commented Jan 12, 2023

@sergey-tihon I'm investigating some details about that if the .dll in the package has some advantages when it's built with .NET7 (size, performance). I read that .NET7 is ~30% faster than .NET6.
Should be ready in the next days.

@CaptnCodr
Copy link
Member Author

CaptnCodr commented Jan 13, 2023

@sergey-tihon There is no difference in size of the libs. Performance is the same tho.
Nevertheless, I would ship it with the STS (.NET7) as we did in the past to be safe here.

@CaptnCodr CaptnCodr merged commit e821351 into fsprojects:master Jan 13, 2023
@CaptnCodr CaptnCodr deleted the feature/NewYear branch January 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants