-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use an upper bound on dependencies, unless you have to #253
Comments
Hey @abelbraaksma, |
The reason why I will update the dependencies in the next PR and tie them to Edit: or tie the |
Actually, you should make If you make it high, you force everybody using your library to also update xUnit, which, as we all know, introduces incompatibilities. You may need to, in which case there's no way out, but in any case, stay as low as you're code allows it. If you can, don't give an upper bound. You don't want to run in the same situation again some day. PS good to know that it's Paket making these decisions. They may make sense in company code, but not in shared libraries. In fact, with quite some public libs, I've seen Paket making weird decisions more often. You want the compatible version as long as possible as low as possible.
So the same would happen again with FSharp.Core or NHamcrest. Maybe Paket is a little too much automation here? |
This has been fixed in v5.6.0 which is now available. |
@CaptnCodr many thanks for the quick resolution! I just upgraded and indeed, the issue doesn't repro anymore. |
Description
Whenever xUnit is updated beyond what this package assumes, NU1608 warnings are raised. This issue was introduced in the latest v5.5.0, it was not present in v5.4.0.
(side note, I don't see any PR for the last 8 days, and the new version is 8 days old, so I can't really find what caused this...)
Repro steps
Just include this library through Nuget and upgrade the xUnit dependency to the latest version 2.6.1
Expected behavior
No warnings.
Actual behavior
Warning:
Known workarounds
Either ignore the warning, or downgrade to FsUnit.xUnit 5.4.0, which does not have this issue.
Related information
Version FsUnit.xUnit 5.5.0
Maybe there's a good reason for not supporting the 2.6+ range, but so far, it works "just fine" if I ignore the warning. In general, dependencies should have a lowest bound, ideally as low as possible for backward compatibility, but no upper bound, for the simple reason that we cannot predict what future versions will bring.
Note that this is how the FSharp.Core dependency was set, no upperbound:
The text was updated successfully, but these errors were encountered: