Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is FSharp.Core 6.0.7 really the lowest dependency for FsUnit? #235

Closed
abelbraaksma opened this issue Jun 5, 2023 · 3 comments · Fixed by #236
Closed

Is FSharp.Core 6.0.7 really the lowest dependency for FsUnit? #235

abelbraaksma opened this issue Jun 5, 2023 · 3 comments · Fixed by #236
Assignees

Comments

@abelbraaksma
Copy link
Member

Description

In version 5.1.0 the F# Core dependency is >= 5.0.2, which is very convenient for a test library, as it allows seamless testing for a large variety of F# versions.

From version 5.2.0 this jumps to >= 6.0.7, which is a big leap and for a bunch of projects (mostly projects that need to use "lowest denominator", like NuGet packages and libs), this causes warnings like these

warning NU1605: Detected package downgrade: FSharp.Core from 6.0.7 to 6.0.3.

Repro steps

Repro is simple: create a lib that uses an older F# Core, then create a test project with FsUnit for it.

Expected behavior

Lowest possible dependency, as this library is widely used. While I understand that a bump to 6.x is necessary at some point (should perhaps be a major version upgrade?), for instance for using task, I would argue that 6.0.2 or thereabouts should be fine.

Actual behavior

See above.

Known workarounds

Use lower dependency, or force-reference F# Core to remove the warning.

@CaptnCodr
Copy link
Member

CaptnCodr commented Jun 5, 2023

Hi @abelbraaksma,
you're right. I didn't change back the FSharp.Core version as I dropped the net7.0 some updates ago.
I'll change this in the next days.

@CaptnCodr CaptnCodr self-assigned this Jun 5, 2023
@abelbraaksma
Copy link
Member Author

Thanks, let me know if I need to test anything for you, happy to help!

@abelbraaksma abelbraaksma changed the title Is FSharp.Core 6.0.7 really the lowest dependency for F# Core? Is FSharp.Core 6.0.7 really the lowest dependency for FsUnit? Jun 5, 2023
@CaptnCodr
Copy link
Member

Hey @abelbraaksma,
this has been released in v5.3.1.

Thank you for your issue! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants