Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines are not correctly failing #204

Closed
Smaug123 opened this issue Mar 31, 2022 · 3 comments
Closed

Pipelines are not correctly failing #204

Smaug123 opened this issue Mar 31, 2022 · 3 comments

Comments

@Smaug123
Copy link
Contributor

Description

#203 at commit bd20cb8 resulted in https://github.com/fsprojects/FsUnit/runs/5778346102 which contains the following:

Starting target 'Format'
Formatted files: { Errors =
          [("/home/runner/work/FsUnit/FsUnit/tests/FsUnit.Xunit.Test/typed.shouldEqualTests.fs",
            Fantomas.FormatConfig+FormatException: Parsing failed with errors: [|tmp.fsx (131,9)-(131,12) parse error The block following this 'let' is unfinished. Every code block is an expression and must have a result. 'let' cannot be the final code element in a block. Consider giving this block an explicit result.|]
And options: { SourceFiles = [|"tmp.fsx"|]
  ConditionalCompilationDefines = []
  ErrorSeverityOptions = { WarnLevel = 3
                           GlobalWarnAsError = false
                           WarnOff = []
                           WarnOn = []
                           WarnAsError = []
                           WarnAsWarn = [] }

That is, it correctly notes that one of my added files is invalid F#.

Despite this, the GitHub Actions pipelines all passed; it was sheer luck that I glanced through the logs.

It seems desirable to make it so that errors cause the pipeline to fail.

@CaptnCodr
Copy link
Member

Is this resolved now?

@Smaug123
Copy link
Contributor Author

Smaug123 commented Apr 4, 2022

If it is fixed, it was fixed by #205. I haven't verified that it is fixed.

@sergey-tihon
Copy link
Member

yes, In this commit 02256b4
I fail build if code is not formatted correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants