Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves to SDK style project files #91

Closed
wants to merge 1 commit into from
Closed

Moves to SDK style project files #91

wants to merge 1 commit into from

Conversation

ChrSteinert
Copy link
Contributor

First step for .NET Standard Support.

I left a few things I believe are not directly necessary like ProjectGuid or BindingRedirects.
Please review and advise!

@panesofglass
Copy link

panesofglass commented Apr 9, 2018

Probably similar to #77 and #80. You could look at #80 for guidance, as I think @enricosada had this working before but then closed his PR. @jackfoxy is also working on this, so you two should collaborate.

@jackfoxy
Copy link
Contributor

jackfoxy commented Apr 21, 2018

@ChrSteinert good work. I made several "improvements" locally. Including adding netstandard2.0 as a target and updating to the latest FSharp.Core.

The travis CI failing may be as simple as adding dotnet : 2.1.4 to .travis.yml, but I am not experienced with Travis.

My "enhanced" local build fails on several (but not all) experimental tests,

Could not load file or assembly 'nunit.framework ...

despite binding redirects that look valid.

The binding redirects are a mess, and should not be necessary in a modern SDK library project. Indeed IMO the entire app.config files should go away. The only way I know for sure to accomplish this is to migrate all the tests to Expecto. That's a bit of a chore.

Perhaps @forki would be so kind as to create a 2.0 branch here, and we could collaborate on that branch.

@ChrSteinert
Copy link
Contributor Author

Cool!
Is this somewhere so we could have a look and proceed from that state further?

@jackfoxy
Copy link
Contributor

@ChrSteinert see #77 (comment)

@ChrSteinert
Copy link
Contributor Author

Closing this as we are working on this over here: https://github.com/jackfoxy/FSharpx.Collections/tree/netstandard

@jackfoxy
Copy link
Contributor

Actually the place to work on this is now here https://github.com/fsprojects/FSharpx.Collections/tree/netstandard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants