New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double-lookup dictionaries: .ContainsKey key followed by indexer call .[key] #706

Open

Thorium opened this issue Mar 15, 2024 · 0 comments

Member

Thorium commented Mar 15, 2024

Avoid double-lookup dictionaries:

.ContainsKey key followed by .[key] should be replaced with .TryGetValue x

for example:

match xs.ContainsKey x with
| true -> ... xs.[x] ...
| false -> ///...

should be replaced with

match xs.TryGetValue x with
| true, xVal -> ... xVal ...
| false, _ -> ///...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment