Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve API doc content alignment #923

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Improve API doc content alignment #923

merged 5 commits into from
Jun 19, 2024

Conversation

brianrourkeboll
Copy link
Member

@brianrourkeboll brianrourkeboll commented Jun 18, 2024 •
edited
Loading

  • Shrink the example heading font size a bit.
  • Align the example with the rest of the summary/details.
  • Improve overall API doc content alignment consistency.

Before & after

before_after.mp4
before_after_ty_extensions.mp4

@brianrourkeboll
Align examples
f4014fb 
* Shrink the example heading font size a bit.

* Align the example with the rest of the summary/details.
nojaf
nojaf approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you want a release for this?

@brianrourkeboll
Copy link
Member Author

Do you want a release for this?

As in another beta?

@nojaf
Copy link
Collaborator

nojaf commented Jun 19, 2024

yes

@brianrourkeboll brianrourkeboll changed the title Align examples in API docs Improve API doc content alignment Jun 19, 2024
nojaf
nojaf approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nojaf nojaf merged commit 1ce0fae into fsprojects:main Jun 19, 2024
3 checks passed
@brianrourkeboll brianrourkeboll deleted the examples branch June 19, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianrourkeboll @nojaf