Minor Seq Optimizations

[1eyewonder]

I was poking around the repo and saw these few spots where I thought we could get some minor performance gains. There are also quite a few areas where we have multiple Seq.Filter's next to each other. I would also like to suggest updating those unless maintainers know of a reason why we have multiple filter iterations next to each other. Hope this helps!

[nojaf]

While I appreciate this PR, the proper thing to do here is most likely a bump of the analyzer tool and packages.
What you detected manually should be caught be a tool.

[nojaf]

Please invert the if/else here, I prefer the negative branch to be the if branch.

[1eyewonder]

I updated to use a local variable to prevent a double negative. Let me know if you prefer to not use this

[nojaf]

I feel like updating the definition of linkNotDefined to linkDefined might also be an option. It is only used once and could probably ne simplified to a List.exist instead of the map/reduce combo.

[1eyewonder]

Thanks for the quick review! I will go ahead and make these changes when I get back from travel early next week

[nojaf]

Thank you, safe travels!

[1eyewonder]

Here are the few areas I see consecutive Seq.filter/List.filter's used. Do you see any reason why we couldn't consolidate to help reduce iterations? The collections may be short enough where they were broken out for readability but I wanted to check to see if we wanted to include in this PR.

1. https://github.com/fsprojects/FSharp.Formatting/blob/main/src/FSharp.Formatting.ApiDocs/GenerateModel.fs#L2424-L2425
2. https://github.com/fsprojects/FSharp.Formatting/blob/main/src/FSharp.Formatting.ApiDocs/GenerateModel.fs#L2451-L2452
3. https://github.com/fsprojects/FSharp.Formatting/blob/main/src/FSharp.Formatting.ApiDocs/GenerateModel.fs#L2464-L2466
4. https://github.com/fsprojects/FSharp.Formatting/blob/main/src/FSharp.Formatting.ApiDocs/GenerateModel.fs#L2621-L2630
5. https://github.com/fsprojects/FSharp.Formatting/blob/main/src/FSharp.Formatting.Common/YaafFSharpScripting.fs#L183-L184
6. https://github.com/fsprojects/FSharp.Formatting/blob/main/src/FSharp.Formatting.Common/YaafFSharpScripting.fs#L284-L294
7. https://github.com/fsprojects/FSharp.Formatting/blob/main/src/FSharp.Formatting.ApiDocs/Categorise.fs#L61-L81

Other than these questions, this PR is ready for review again 👍

[nojaf]

Here are the few areas I see consecutive Seq.filter/List.filter's used. Do you see any reason why we couldn't consolidate to help reduce iterations?

This codebase is rather old and has many authors. I don't believe there is a good reason these cases are not combined. Could you address these as well?

[nojaf]

Thanks!