Add expand/collapse-all button for API doc details #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianrourkeboll
commented
Jun 4, 2024
nojaf
approved these changes
Jun 5, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the other suggestion in #916.
expand-collapse-3.mp4
I have the buttons operating on the entire document. When toggled, the preference (all expanded or all collapsed) is saved to local storage. An alternative could have been to have independent expand/collapse-all buttons for each section (e.g., constructors instance members, static members, etc.), and no persistence to local storage.
To maintain parity with the behavior of the theme toggle button, I have the new button showing the state that clicking it will cause rather than the current state, even though I think I might personally prefer it the other way around.